-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[ Tool ] Only listen for DebugConnectionInfo if the service protocol is supported #174664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…is supported Fixes #174330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue where flutter run --wasm --machine
would hang. The fix involves checking if the service protocol is supported before attempting to listen for debug connection information.
In packages/flutter_tools/lib/src/commands/daemon.dart
, the condition for setting up the DebugConnectionInfo
completer is updated to include a check for runner.supportsServiceProtocol
. This prevents waiting for a debug port on platforms without service protocol support, such as WASM.
To enable testing of this change, packages/flutter_tools/test/integration.shard/test_driver.dart
is modified to include a wasm
flag. This flag controls the --wasm
argument for the flutter run
command and adjusts the waitForDebugPort
logic accordingly.
A new regression test is added in packages/flutter_tools/test/web.shard/web_run_chrome_test.dart
to confirm that flutter run --wasm --machine
on Chrome devices now works as expected without hanging.
The changes are self-contained and include a regression test. I have no further comments or suggestions.
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
… protocol is supported (flutter/flutter#174664)
Fixes #174330