Skip to content

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Aug 28, 2025

Fixes #174330

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where flutter run --wasm --machine would hang. The fix involves checking if the service protocol is supported before attempting to listen for debug connection information.

In packages/flutter_tools/lib/src/commands/daemon.dart, the condition for setting up the DebugConnectionInfo completer is updated to include a check for runner.supportsServiceProtocol. This prevents waiting for a debug port on platforms without service protocol support, such as WASM.

To enable testing of this change, packages/flutter_tools/test/integration.shard/test_driver.dart is modified to include a wasm flag. This flag controls the --wasm argument for the flutter run command and adjusts the waitForDebugPort logic accordingly.

A new regression test is added in packages/flutter_tools/test/web.shard/web_run_chrome_test.dart to confirm that flutter run --wasm --machine on Chrome devices now works as expected without hanging.

The changes are self-contained and include a regression test. I have no further comments or suggestions.

@auto-submit auto-submit bot added this pull request to the merge queue Aug 29, 2025
Merged via the queue into master with commit 89ba8a0 Aug 29, 2025
152 checks passed
@auto-submit auto-submit bot deleted the fix_issue_174330 branch August 29, 2025 01:54
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter Web WASM getting crash
3 participants