-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[ Widget Preview ] Respond to IDE navigation events and show previews from the currently focused script #174466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 6 commits into
master
from
widget_previews_selected_script_responsive
Sep 2, 2025
Merged
[ Widget Preview ] Respond to IDE navigation events and show previews from the currently focused script #174466
auto-submit
merged 6 commits into
master
from
widget_previews_selected_script_responsive
Sep 2, 2025
+878
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from the currently focused script This change allows for the widget previewer to react to `activeLocationChanged` events sent over the `Editor` DTD service to automatically filter the set of visible previews based on the currently selected file in the IDE. This functionality can be turned on or off depending on whether or not the developer wants to see all previews in the project at once. This change also includes some minor refactoring and UI changes to move the widget preview environment controls to a reserved area at the bottom of the preview window.
LongCatIsLooong
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
...s/flutter_tools/templates/widget_preview_scaffold/lib/src/widget_preview_rendering.dart.tmpl
Outdated
Show resolved
Hide resolved
...tools/templates/widget_preview_scaffold/lib/src/widget_preview_scaffold_controller.dart.tmpl
Outdated
Show resolved
Hide resolved
...tools/templates/widget_preview_scaffold/lib/src/widget_preview_scaffold_controller.dart.tmpl
Show resolved
Hide resolved
...tools/templates/widget_preview_scaffold/lib/src/widget_preview_scaffold_controller.dart.tmpl
Show resolved
Hide resolved
packages/flutter_tools/templates/widget_preview_scaffold/lib/src/controls.dart.tmpl
Show resolved
Hide resolved
Thanks for reviewing @LongCatIsLooong |
...tools/templates/widget_preview_scaffold/lib/src/widget_preview_scaffold_controller.dart.tmpl
Outdated
Show resolved
Hide resolved
Thanks so much for the review! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2025
…w previews from the currently focused script (flutter/flutter#174466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2025
…w previews from the currently focused script (flutter/flutter#174466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for the widget previewer to react to
activeLocationChanged
events sent over theEditor
DTD service to automatically filter the set of visible previews based on the currently selected file in the IDE. This functionality can be turned on or off depending on whether or not the developer wants to see all previews in the project at once.This change also includes some minor refactoring and UI changes to move the widget preview environment controls to a reserved area at the bottom of the preview window.
Demo:
Screen.Recording.2025-08-26.at.4.40.22.PM.mov