Skip to content

[SliderTheme] Fix markdown links for api doc images #152748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

royarg02
Copy link
Contributor

@royarg02 royarg02 commented Aug 2, 2024

Fixes incorrect syntax of image links for the api documentation of the following classes:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 2, 2024
Copy link
Member

@piedcipher piedcipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Minor space, otherwise LGTM!

Copy link
Member

@piedcipher piedcipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@piedcipher piedcipher force-pushed the slider-theme-api-images branch from 4a5d92e to 4f2f16c Compare August 2, 2024 18:35
Fixes incorrect syntax of image links for the api documentation of the
following classes:

- RectangularSliderTrackShape
- RoundedRectSliderTrackShape
- RectangularRangeSliderTrackShape
- RoundedRectRangeSliderTrackShape
- RoundSliderTickMarkShape
- RoundRangeSliderTickMarkShape
- RoundSliderThumbShape
- RoundRangeSliderThumbShape
- RectangularSliderValueIndicatorShape
- RectangularRangeSliderValueIndicatorShape
- PaddleSliderValueIndicatorShape
- PaddleRangeSliderValueIndicatorShape
@piedcipher piedcipher force-pushed the slider-theme-api-images branch from 4f2f16c to 0004660 Compare August 2, 2024 19:48
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, many thanks ❤️

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2024
@auto-submit auto-submit bot merged commit 419f023 into flutter:master Aug 2, 2024
73 checks passed
@royarg02 royarg02 deleted the slider-theme-api-images branch August 4, 2024 07:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 4, 2024
Manual roll requested by [email protected]

flutter/flutter@f10a497...cbfb222

2024-08-04 [email protected] Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) (flutter/flutter#152824)
2024-08-03 [email protected] Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) (flutter/flutter#152821)
2024-08-03 [email protected] Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) (flutter/flutter#152818)
2024-08-03 [email protected] Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) (flutter/flutter#152814)
2024-08-03 [email protected] Fix device_os requested in linux_build_test tests (flutter/flutter#152808)
2024-08-03 [email protected] Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) (flutter/flutter#152804)
2024-08-03 [email protected] Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (flutter/flutter#152796)
2024-08-03 [email protected] Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) (flutter/flutter#152790)
2024-08-03 [email protected] Improve `CupertinoRadio` fidelity (flutter/flutter#149703)
2024-08-03 [email protected] Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) (flutter/flutter#152777)
2024-08-02 [email protected] Fix handling of `iconSize` and `iconColor` defaults for `ButtonStyleButton` subclasses. (flutter/flutter#143501)
2024-08-02 [email protected] Use print logging on LUCI. (flutter/flutter#152776)
2024-08-02 [email protected] Reland: Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152756)
2024-08-02 [email protected] Write more on Animation and related docs (flutter/flutter#150727)
2024-08-02 [email protected] Quick Grammar Fixes  (flutter/flutter#152744)
2024-08-02 [email protected] Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) (flutter/flutter#152762)
2024-08-02 [email protected] [SliderTheme] Fix markdown links for api doc images (flutter/flutter#152748)
2024-08-02 [email protected] Make the App's title optional on web (flutter/flutter#152003)
2024-08-02 [email protected] Add tests for scaffold messenger state (flutter/flutter#152735)
2024-08-02 [email protected] Ignore both unused_element and unused_element_parameter (flutter/flutter#152689)
2024-08-02 [email protected] Update dartdoc to 8.0.12 to fix focusing search field (flutter/flutter#151576)
2024-08-02 [email protected] [wiki] Remove outdated warning about stale coverage data (flutter/flutter#152560)
2024-08-02 [email protected] Roll Packages from 27896d1 to cc9ff47 (8 revisions) (flutter/flutter#152754)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
Fixes incorrect syntax of image links for the api documentation of the following classes:

- [RectangularSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularSliderTrackShape-class.html)
- [RoundedRectSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectSliderTrackShape-class.html)
- [RectangularRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderTrackShape-class.html)
- [RoundedRectRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectRangeSliderTrackShape-class.html)
- [RoundSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundSliderTickMarkShape-class.html)
- [RoundRangeSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderTickMarkShape-class.html)
- [RoundSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundSliderThumbShape-class.html)
- [RoundRangeSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderThumbShape-class.html)
- [RectangularSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularSliderValueIndicatorShape-class.html)
- [RectangularRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderValueIndicatorShape-class.html)
- [PaddleSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleSliderValueIndicatorShape-class.html)
- [PaddleRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleRangeSliderValueIndicatorShape-class.html)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Fixes incorrect syntax of image links for the api documentation of the following classes:

- [RectangularSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularSliderTrackShape-class.html)
- [RoundedRectSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectSliderTrackShape-class.html)
- [RectangularRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderTrackShape-class.html)
- [RoundedRectRangeSliderTrackShape](https://main-api.flutter.dev/flutter/material/RoundedRectRangeSliderTrackShape-class.html)
- [RoundSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundSliderTickMarkShape-class.html)
- [RoundRangeSliderTickMarkShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderTickMarkShape-class.html)
- [RoundSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundSliderThumbShape-class.html)
- [RoundRangeSliderThumbShape](https://main-api.flutter.dev/flutter/material/RoundRangeSliderThumbShape-class.html)
- [RectangularSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularSliderValueIndicatorShape-class.html)
- [RectangularRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/RectangularRangeSliderValueIndicatorShape-class.html)
- [PaddleSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleSliderValueIndicatorShape-class.html)
- [PaddleRangeSliderValueIndicatorShape](https://main-api.flutter.dev/flutter/material/PaddleRangeSliderValueIndicatorShape-class.html)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants