[flutter_tools] pass through enable impeller flag to macOS. #128720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
jonahwilliams
changed the title
| @@ -300,6 +300,82 @@ void main() { | |||
| ), | |||
| ); | |||
| }); | |||
|
|
|||
| testWithoutContext('Device devices that support impeller pass through the enable-impeller flag', () async { | |||
There was a problem hiding this comment.
Did you mean "Desktop devices"?
Suggested change
| testWithoutContext('Device devices that support impeller pass through the enable-impeller flag', () async { | |
| testWithoutContext('Desktop devices that support impeller pass through the enable-impeller flag', () async { |
There was a problem hiding this comment.
lol yes, thanks
| processManager: processManager, | ||
| supportsImpeller: true, | ||
| ); | ||
| unawaited(Future<void>(() { |
There was a problem hiding this comment.
Why is this unawaited?
There was a problem hiding this comment.
Copy paste, removed
| ); | ||
| }); | ||
|
|
||
| testWithoutContext('Device devices that do not support impeller ignore the enable-impeller flag', () async { |
There was a problem hiding this comment.
Suggested change
| testWithoutContext('Device devices that do not support impeller ignore the enable-impeller flag', () async { | |
| testWithoutContext('Desktop devices that do not support impeller ignore the enable-impeller flag', () async { |
|
Technically this doesn't work until flutter/engine#42639 rolls in, but its not harmful to land before that as it doesn't change behavior. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 14, 2023
flutter/flutter@353b8bc...09b7e56 2023-06-13 [email protected] Roll Packages from c9865e8 to 0507297 (6 revisions) (flutter/flutter#128796) 2023-06-13 [email protected] Roll Flutter Engine from 346f051ac062 to f9a0a0dafeea (1 revision) (flutter/flutter#128786) 2023-06-13 [email protected] Roll Flutter Engine from 5951f90cbac3 to 346f051ac062 (1 revision) (flutter/flutter#128783) 2023-06-13 [email protected] Roll Flutter Engine from 3b70103f53bc to 5951f90cbac3 (1 revision) (flutter/flutter#128781) 2023-06-13 [email protected] Roll Flutter Engine from 04ffeb4ab103 to 3b70103f53bc (1 revision) (flutter/flutter#128778) 2023-06-13 [email protected] Roll Flutter Engine from 42ccd12a14c2 to 04ffeb4ab103 (4 revisions) (flutter/flutter#128772) 2023-06-13 [email protected] Roll Flutter Engine from aa1693f6aaeb to 42ccd12a14c2 (1 revision) (flutter/flutter#128761) 2023-06-13 [email protected] Roll Flutter Engine from d02b15ef34ef to aa1693f6aaeb (3 revisions) (flutter/flutter#128759) 2023-06-13 [email protected] Roll Flutter Engine from f67ed35b142e to d02b15ef34ef (2 revisions) (flutter/flutter#128754) 2023-06-13 [email protected] Roll Flutter Engine from 1714d73e681b to f67ed35b142e (3 revisions) (flutter/flutter#128751) 2023-06-12 [email protected] Roll Flutter Engine from 12def739b1f6 to 1714d73e681b (2 revisions) (flutter/flutter#128738) 2023-06-12 [email protected] Fix paint offset in reverse for 2D (flutter/flutter#128724) 2023-06-12 [email protected] [flutter_tools] pass through enable impeller flag to macOS. (flutter/flutter#128720) 2023-06-12 [email protected] Roll Flutter Engine from de68fba09338 to 12def739b1f6 (2 revisions) (flutter/flutter#128726) 2023-06-12 [email protected] Roll Flutter Engine from 33e06934daed to de68fba09338 (10 revisions) (flutter/flutter#128721) 2023-06-12 [email protected] Roll Flutter Engine from 4b022f4e871f to 33e06934daed (6 revisions) (flutter/flutter#128706) 2023-06-12 [email protected] Update button tests for Material 3 by default (flutter/flutter#128628) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing through the --enable-impeller flag to macOS.