Verify EditableText fires update on replaced controller #12276
Conversation
|
Adds test to cover #12154. |
| cursorColor: Colors.blue, | ||
| selectionControls: materialTextSelectionControls, | ||
| keyboardType: TextInputType.text, | ||
| onChanged: (String value) {}, |
There was a problem hiding this comment.
trivial nit: style guide says to use {} for empty maps and { } for empty code blocks
|
|
||
| final MethodCall setStateCall = log.firstWhere((MethodCall methodCall) { | ||
| return methodCall.method == 'TextInput.setEditingState'; | ||
| }); |
There was a problem hiding this comment.
would it make sense to be more precise about what should be in the log? e.g. that it only has one entry, or whatnot? What if there were two calls, one saying Wobble and one saying Wibble?
There was a problem hiding this comment.
Done. Was worried about testing some assumptions we don't care about here but the result is under-testing, and if someone's going to tweak this code, we should probably force them to check these tests anyway :-)
|
FWIW what I usually do with these logs is have the log be a List and have whatever adds stuff to the logs add a description of what it cares about (e.g. method name, argument contents), and then in the expects call i just match the entire list with exactly what all the strings should be. |
Adds a test that verifies that EditableText sends a TextInput.setEditingState message to the engine when the associated TextEditingController is replaced.
cbracken
force-pushed
the
controller-update-test
branch
from
d13c670 to
780522f
Compare
Adds a test that verifies that EditableText sends a
TextInput.setEditingState message to the engine when the associated
TextEditingController is replaced.