Guess sign iOS with the first certificate when running in machine mode #10870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Jun 22, 2017
| '' | ||
| )); | ||
| mockTerminalStdInStream = | ||
| new Stream<String>.fromFuture(new Future<String>.error(new Exception('Cannot read from StdIn'))); |
There was a problem hiding this comment.
Hard to tell from surrounding code but it doesn't appear that this is ever used.
There was a problem hiding this comment.
ya, it's not actually used. Just a negative check in case it does, that it would crash like it would in production.
tvolkert
approved these changes
Jun 22, 2017
| mode: mode, | ||
| target: mainPath, | ||
| buildForDevice: true, | ||
| usesTerminalUi: usesTerminalUi |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
flutter#10870) * Guess sign with the first certificate when multiple are available in machine mode * review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10626
Found another better signal that could be used for this determination without adding new logic