Add version information to dartdoc footer #10844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@jcollins-g, what does the footer look like w/ this change? I suspect that we'll insert the version, date, and git hash, which may be a bit much. We may want to drop one or more of those. |
devoncarew
reviewed
Jun 19, 2017
dev/tools/dartdoc.dart
Outdated
| // Create the pubspec.yaml file. | ||
| final StringBuffer buf = new StringBuffer(''' | ||
| name: Flutter | ||
| version: ${version.toString()} |
There was a problem hiding this comment.
Just $version should be enough here.
|
The footer does indeed include all of those, now. But I don't know if it is helpful or not to continue to have the git tag in the presence of the version. It probably is for bleeding edge but less so elsewhere. I'll let reviewers weigh in.
|
|
It might be nice to to drop the git hash for git branches == lgtm |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
* Add version information to dartdoc footer * Add final to variable declaration * Drop toString()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10787 by adding the version field to the generated pubspec.yaml.