-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
There's a framework test called fuchsia_precache
which runs (in presubmit on every PR) flutter precache --fuchsia
in a Linux VM #139202
Lines 1620 to 1642 in 0d528b8
Future<void> _runFuchsiaPrecache() async { | |
printProgress('${green}Running flutter precache tests$reset'); | |
await runCommand( | |
'flutter', | |
<String>[ | |
'config', | |
'--enable-fuchsia', | |
], | |
workingDirectory: flutterRoot, | |
); | |
await runCommand( | |
'flutter', | |
<String>[ | |
'precache', | |
'--flutter_runner', | |
'--fuchsia', | |
'--no-android', | |
'--no-ios', | |
'--force', | |
], | |
workingDirectory: flutterRoot, | |
); | |
} |
However it looks like this was never intended to be a tool precache test, it was a Cirrus pseudo setup task to make sure the fuchsia artifacts are available on the bot before rolling the engine #50822 and was moved to https://flutter-review.googlesource.com/c/recipes/+/5120.
Zach mentions this may be the only place before the g3 roll that checks if those artifacts were published, so it would be good to keep for engine roll presubmits.
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.