iOS platform view opacity #9667

cyanglaz · 2019-07-03T21:37:47Z

Raster_cache optimization is not included in this PR.

cyanglaz · 2019-07-03T21:43:42Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -299,6 +306,7 @@
  UIView* touchInterceptor = touch_interceptors_[view_id].get();
  touchInterceptor.layer.transform = CATransform3DIdentity;
  touchInterceptor.frame = frame;
+  touchInterceptor.alpha = 1;


I think since we are adding more stuff here and might add even more later, we can have a possible refactoring to make a separate method to do all of these: ResetEmbeddedViewMutation(int view_id, EmbeddedViewParams params)

amirh · 2019-07-08T18:38:05Z

flow/embedded_views.h

+// Matches the members in a `OpacityLayer`.
+struct OpacityParams {
+  std::reference_wrapper<int> alpha;
+  std::reference_wrapper<SkPoint> offset;


Haven't read the rest of the PR yet, but looking at this I'm not sure what does an offset means for opacity, should probably add a comment.

amirh · 2019-07-08T18:40:14Z

flow/embedded_views.h

+    return !operator==(other);
+  }
+
+  float GetAlphaF() const { return (alpha / 255.0); }


This should be a class if we include such a method, see: https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes

amirh · 2019-07-08T18:40:52Z

flow/embedded_views.h

@@ -42,6 +59,9 @@ class Mutator {
      case transform:
        matrix_ = other.matrix_;
        break;
+      case opacity:
+        opacityParams_ = OpacityParams{other.opacityParams_.alpha,
+                                       other.opacityParams_.offset};


missing break;

amirh · 2019-07-08T18:59:58Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+        if ((*iter)->GetOpacityParams().offset.get().isZero()) {
+          break;
+        }
+        CATransform3D transform =


Why are we bundling a transform with the opacity vs. pushing a separate transform mutator?

cyanglaz · 2019-07-08T21:10:14Z

@amirh Updated with review comments. I finally decided to separate opacity with the offset.

amirh

LGTM modulo nit

amirh · 2019-07-08T21:39:24Z

flow/embedded_views.h


  const MutatorType& GetType() const { return type_; }
  const SkRect& GetRect() const { return rect_; }
  const SkRRect& GetRRect() const { return rrect_; }
  const SkPath& GetPath() const { return *path_; }
  const SkMatrix& GetMatrix() const { return matrix_; }
+  const int& GetAlpha() const { return alpha_; }
+  float GetAlphaF() const { return (alpha_ / 255.0); }


nit: is F for float here? if so maybe call it GetAlphaFloat?

flutter/engine@75387db...49445ce git log 75387db..49445ce --no-merges --oneline 49445ce FLEViewController/Engine API changes (flutter/engine#9750) 2a79462 Add Fuchsia build CI presubmit steps (flutter/engine#9736) 67cebdb Roll fuchsia/sdk/core/linux-amd64 from KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC to ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC (flutter/engine#9765) 089c740 Roll fuchsia/sdk/core/mac-amd64 from lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C to EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C (flutter/engine#9759) b22410e Include SkParagraph headers only when the enable-skshaper flag is on (flutter/engine#9758) 2cd650d Minimal integration with the Skia text shaper module (flutter/engine#9556) f775f5e Re-enable the Wuffs GIF decoder (flutter/engine#9466) aca0482 Make all shell unit tests use the OpenGL rasterizer. (flutter/engine#9746) bc57291 Make FLEViewController's view an internal detail (flutter/engine#9741) 9776043 Synchronize main thread and gpu thread for first render frame (flutter/engine#9506) f600ae8 Use libc++ variant of string view and remove the FML variant. (flutter/engine#9737) 564f53f Revert "Improve caching limits for Skia (#9503)" (flutter/engine#9740) b453d3c libtxt: fix reference counting of SkFontStyleSets held by font asset providers (flutter/engine#9561) fa7627d Fix backspace crash on Chinese devices (flutter/engine#9734) 56885f7 Let pushColorFilter accept all types of ColorFilters (flutter/engine#9641) 6dccb21 Roll src/third_party/skia 96fdfe0fe88e..af4e7b6cf616 (1 commits) (flutter/engine#9735) 8511d9b Roll fuchsia/sdk/core/mac-amd64 from byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC to lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C (flutter/engine#9742) b3bf0a1 Roll fuchsia/sdk/core/linux-amd64 from I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C to KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC (flutter/engine#9743) 7e56823 Fix windows test by not attempting to open a directory as a file. (flutter/engine#9745) 6cf0d13 Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (flutter/engine#9731) 49a00ae Fix Fuchsia build. (flutter/engine#9730) b3bb39b Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (flutter/engine#9728) 2284210 Make the license script compatible with recently changed Dart I/O stream APIs (flutter/engine#9725) ad582b5 Rework image & texture management to use concurrent message queues. (flutter/engine#9486) 1dcd5f5 Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (flutter/engine#9726) 129979c Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)" (flutter/engine#9724) 8020d7e Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (flutter/engine#9718) e24bd78 Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits) 3d2668c Reland isolate group changes 802bd15 iOS platform view opacity (flutter/engine#9667) 3b6265b Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits) 887e052 Refactor ColorFilter to have a native wrapper (flutter/engine#9668) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.

flutter/engine@75387db...49445ce git log 75387db..49445ce --no-merges --oneline 49445ce FLEViewController/Engine API changes (flutter/engine#9750) 2a79462 Add Fuchsia build CI presubmit steps (flutter/engine#9736) 67cebdb Roll fuchsia/sdk/core/linux-amd64 from KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC to ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC (flutter/engine#9765) 089c740 Roll fuchsia/sdk/core/mac-amd64 from lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C to EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C (flutter/engine#9759) b22410e Include SkParagraph headers only when the enable-skshaper flag is on (flutter/engine#9758) 2cd650d Minimal integration with the Skia text shaper module (flutter/engine#9556) f775f5e Re-enable the Wuffs GIF decoder (flutter/engine#9466) aca0482 Make all shell unit tests use the OpenGL rasterizer. (flutter/engine#9746) bc57291 Make FLEViewController&flutter#39;s view an internal detail (flutter/engine#9741) 9776043 Synchronize main thread and gpu thread for first render frame (flutter/engine#9506) f600ae8 Use libc&flutter#43;&flutter#43; variant of string view and remove the FML variant. (flutter/engine#9737) 564f53f Revert &flutter#34;Improve caching limits for Skia (flutter#9503)&flutter#34; (flutter/engine#9740) b453d3c libtxt: fix reference counting of SkFontStyleSets held by font asset providers (flutter/engine#9561) fa7627d Fix backspace crash on Chinese devices (flutter/engine#9734) 56885f7 Let pushColorFilter accept all types of ColorFilters (flutter/engine#9641) 6dccb21 Roll src/third_party/skia 96fdfe0fe88e..af4e7b6cf616 (1 commits) (flutter/engine#9735) 8511d9b Roll fuchsia/sdk/core/mac-amd64 from byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC to lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C (flutter/engine#9742) b3bf0a1 Roll fuchsia/sdk/core/linux-amd64 from I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C to KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC (flutter/engine#9743) 7e56823 Fix windows test by not attempting to open a directory as a file. (flutter/engine#9745) 6cf0d13 Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (flutter/engine#9731) 49a00ae Fix Fuchsia build. (flutter/engine#9730) b3bb39b Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (flutter/engine#9728) 2284210 Make the license script compatible with recently changed Dart I/O stream APIs (flutter/engine#9725) ad582b5 Rework image & texture management to use concurrent message queues. (flutter/engine#9486) 1dcd5f5 Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (flutter/engine#9726) 129979c Revert &flutter#34;Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)&flutter#34; (flutter/engine#9724) 8020d7e Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (flutter/engine#9718) e24bd78 Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits) 3d2668c Reland isolate group changes 802bd15 iOS platform view opacity (flutter/engine#9667) 3b6265b Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits) 887e052 Refactor ColorFilter to have a native wrapper (flutter/engine#9668) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.

Chris Yang and others added 10 commits June 29, 2019 12:21

disable mysterious failing tests

92d9b3d

draft

b8a9f6f

merge upstream

cf1c701

refactoring

8583580

formatting

740e857

opacity

eec1c24

Merge branch 'master' into ios_platform_view_opacity

f9373b2

add OpacityParams

ee78ff9

make OpacityParams members to be references

23c6807

merge master

82652cc

cyanglaz requested a review from amirh July 3, 2019 21:37

googlebot added the cla: yes label Jul 3, 2019

cyanglaz commented Jul 3, 2019

View reviewed changes

cleanup

a7e3427

amirh reviewed Jul 8, 2019

View reviewed changes

review fixes

ce8bad5

amirh approved these changes Jul 8, 2019

View reviewed changes

rename GetAlphaF to GetAlphaFloat

fa898f5

cyanglaz merged commit 802bd15 into flutter:master Jul 8, 2019

cyanglaz deleted the ios_platform_view_opacity branch July 8, 2019 23:07

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

1a3d583

This was referenced Jul 9, 2019

Roll engine e695a516f148..802bd1518b30 (11 commits) flutter/flutter#35776

Closed

Roll engine e695a516f148..e24bd78462cf (13 commits) flutter/flutter#35816

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

0373527

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

be06f5d

This was referenced Jul 9, 2019

Roll engine e695a516f148..8020d7e4346c (14 commits) flutter/flutter#35817

Closed

Roll engine e695a516f148..129979cabab2 (15 commits) flutter/flutter#35819

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

b4b0453

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

0f84abe

This was referenced Jul 9, 2019

Roll engine 75387dbc147d..2284210f4275 (10 commits) flutter/flutter#35830

Closed

Roll engine 75387dbc147d..b3bb39b0b18e (11 commits) flutter/flutter#35834

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

f45aa28

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

0ff9963

This was referenced Jul 10, 2019

Roll engine 75387dbc147d..49a00aed8cee (12 commits) flutter/flutter#35841

Closed

Roll engine 75387dbc147d..49a00aed8cee (12 commits) flutter/flutter#35873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

9cbda86

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

2025a90

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..7e568232a51e (14 commits) flutter/flutter#35895

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

6532c15

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..b453d3c3ddcb (20 commits) flutter/flutter#35908

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

c9be498

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..f600ae830d6c (22 commits) flutter/flutter#35916

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

d40d94a

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..9776043ea505 (23 commits) flutter/flutter#35922

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

d210973

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..bc57291ff44f (24 commits) flutter/flutter#35925

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 10, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

d8d2c46

engine-flutter-autoroll mentioned this pull request Jul 10, 2019

Roll engine 75387dbc147d..f775f5e4d637 (26 commits) flutter/flutter#35930

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

0631918

engine-flutter-autoroll mentioned this pull request Jul 11, 2019

Roll engine 75387dbc147d..b22410ef6b11 (28 commits) flutter/flutter#35944

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

e018407

engine-flutter-autoroll mentioned this pull request Jul 11, 2019

Roll engine 75387dbc147d..089c740841e8 (29 commits) flutter/flutter#35947

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

2c0f71c

engine-flutter-autoroll mentioned this pull request Jul 11, 2019

Roll engine 75387dbc147d..67cebdb926a4 (30 commits) flutter/flutter#35949

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

802bd15 iOS platform view opacity (flutter/engine#9667)

9a30e45

engine-flutter-autoroll mentioned this pull request Jul 11, 2019

Roll engine 75387dbc147d..49445ce4949b (32 commits) flutter/flutter#35952

Merged

amirh mentioned this pull request Jul 17, 2019

UiKitViews don't support opacity flutter/flutter#24165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

iOS platform view opacity #9667

iOS platform view opacity #9667

Uh oh!

cyanglaz commented Jul 3, 2019

Uh oh!

cyanglaz Jul 3, 2019

Uh oh!

amirh Jul 8, 2019

Uh oh!

amirh Jul 8, 2019

Uh oh!

amirh Jul 8, 2019

Uh oh!

amirh Jul 8, 2019

Uh oh!

cyanglaz commented Jul 8, 2019

Uh oh!

amirh left a comment

Uh oh!

amirh Jul 8, 2019

Uh oh!

Uh oh!

iOS platform view opacity #9667

iOS platform view opacity #9667

Uh oh!

Conversation

cyanglaz commented Jul 3, 2019

Uh oh!

cyanglaz Jul 3, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

cyanglaz commented Jul 8, 2019

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!