Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

make drain perform cleanup #9004

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion flow/skia_gpu_object.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@

#include "flutter/fml/message_loop.h"

#include <chrono>

namespace flutter {

SkiaUnrefQueue::SkiaUnrefQueue(fml::RefPtr<fml::TaskRunner> task_runner,
fml::TimeDelta delay)
fml::TimeDelta delay,
fml::WeakPtr<GrContext> context)
: task_runner_(std::move(task_runner)),
drain_delay_(delay),
context_(context),
drain_pending_(false) {}

SkiaUnrefQueue::~SkiaUnrefQueue() {
Expand Down Expand Up @@ -39,6 +43,9 @@ void SkiaUnrefQueue::Drain() {
for (SkRefCnt* skia_object : skia_objects) {
skia_object->unref();
}
if (context_) {
context_->performDeferredCleanup(std::chrono::milliseconds(250));
}
}

} // namespace flutter
5 changes: 4 additions & 1 deletion flow/skia_gpu_object.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "flutter/fml/memory/weak_ptr.h"
#include "flutter/fml/task_runner.h"
#include "third_party/skia/include/core/SkRefCnt.h"
#include "third_party/skia/include/gpu/GrContext.h"

namespace flutter {

Expand All @@ -31,12 +32,14 @@ class SkiaUnrefQueue : public fml::RefCountedThreadSafe<SkiaUnrefQueue> {
private:
const fml::RefPtr<fml::TaskRunner> task_runner_;
const fml::TimeDelta drain_delay_;
const fml::WeakPtr<GrContext> context_;
std::mutex mutex_;
std::deque<SkRefCnt*> objects_;
bool drain_pending_;

SkiaUnrefQueue(fml::RefPtr<fml::TaskRunner> task_runner,
fml::TimeDelta delay);
fml::TimeDelta delay,
fml::WeakPtr<GrContext> context);

~SkiaUnrefQueue();

Expand Down
3 changes: 2 additions & 1 deletion shell/common/shell_io_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ ShellIOManager::ShellIOManager(
: nullptr),
unref_queue_(fml::MakeRefCounted<flutter::SkiaUnrefQueue>(
std::move(unref_queue_task_runner),
fml::TimeDelta::FromMilliseconds(250))),
fml::TimeDelta::FromMilliseconds(250),
resource_context_weak_factory_->GetWeakPtr())),
weak_factory_(this) {
if (!resource_context_) {
#ifndef OS_FUCHSIA
Expand Down