This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Wire up Fuchsia SDK related updated for shell dependencies. #8869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not acutally import the runners into the engine. Only sets up the targets so they need no modifications when the migration is done. The engine is still buildable in both buildroots.
Member
Author
|
The patches after this are mostly just copies of the source code of the runner into the engine. |
jason-simmons
approved these changes
May 7, 2019
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
May 28, 2019
This fixes a regression I introduced in flutter#8869 while preparing the buildroot for Fuchsia.
chinmaygarde
added a commit
that referenced
this pull request
May 28, 2019
This fixes a regression I introduced in #8869 while preparing the buildroot for Fuchsia.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
This fixes a regression I introduced in flutter#8869 while preparing the buildroot for Fuchsia.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not actually import the runners into the engine. It only sets up the targets so they need no modifications are necessary when the migration is done. The engine has been verified to build in both buildroots.