Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add hasImplicitScrolling SemanticFlag and support in Android bridge #5941

Merged
merged 2 commits into from
Aug 6, 2018
Merged

Add hasImplicitScrolling SemanticFlag and support in Android bridge #5941

merged 2 commits into from
Aug 6, 2018

Conversation

jonahwilliams
Copy link
Contributor

When a user navigates to the end of a visible viewport, there are two behaviors that Talkback supports: 1) it can attempt to scroll the next element from the current viewport into view, like in a List or 2) it can continue the a11y traversal as if the offscreen elements aren't there.

The latter behavior isn't exposed by us, but is necessary for a widget such as a TabBar - with implicit scrolling enabled a user would have to navigate to the end of the scrollable tabs before they can navigate into the tab body. With this change, we can configure it such that reaching the end of the visible tabs will immediately move to the tab body instead.

For more context see: flutter/flutter#19917

We already have this information on the framework side with https://master-docs-flutter-io.firebaseapp.com/flutter/widgets/ScrollPhysics/allowImplicitScrolling.html

@jonahwilliams jonahwilliams mentioned this pull request Aug 4, 2018
Merged
1 task
@jonahwilliams jonahwilliams merged commit a5215ce into flutter:master Aug 6, 2018
@jonahwilliams jonahwilliams deleted the horizontal_scroll_view branch August 6, 2018 20:57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine ecbb2b2..a5215ce (9 commits)
5cc58b2 
flutter/engine@ecbb2b2...a5215ce

git log ecbb2b2..a5215ce --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-06 [email protected] Add hasImplicitScrolling SemanticFlag and support in Android bridge (flutter/engine#5941)
2018-08-06 37626415+[email protected] Roll src/third_party/skia 6e487e67a3f3..641ac7daa81c (16 commits) (flutter/engine#5948)
2018-08-06 [email protected] Updated background execution implementation for Android
2018-08-06 37626415+[email protected] Roll src/third_party/skia 12fb9cfeee07..6e487e67a3f3 (8 commits) (flutter/engine#5946)
2018-08-06 37626415+[email protected] Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
@jonahwilliams jonahwilliams mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine ecbb2b2..5442c0a (10 commits)
412e709 
flutter/engine@ecbb2b2...5442c0a

git log ecbb2b2..5442c0a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-06 [email protected] Revert "Updated background execution implementation for Android" (flutter/engine#5949)
2018-08-06 [email protected] Add hasImplicitScrolling SemanticFlag and support in Android bridge (flutter/engine#5941)
2018-08-06 37626415+[email protected] Roll src/third_party/skia 6e487e67a3f3..641ac7daa81c (16 commits) (flutter/engine#5948)
2018-08-06 [email protected] Updated background execution implementation for Android
2018-08-06 37626415+[email protected] Roll src/third_party/skia 12fb9cfeee07..6e487e67a3f3 (8 commits) (flutter/engine#5946)
2018-08-06 37626415+[email protected] Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
@liyuqian liyuqian mentioned this pull request Aug 7, 2018
Merged
liyuqian added a commit to liyuqian/flutter that referenced this pull request Aug 7, 2018
@liyuqian
Roll engine to 7f083e5
180d88a 
7f083e5 Don't implicitly fall through in switch statement (flutter/engine#5964)
c7ce6dd Apply translation to accessibility tree when in landscape (flutter/engine#5950)
aef94b7 Reland "Updated background execution implementation for Android" (flutter/engine#5954)
3421bca Roll src/third_party/skia 36216fb0acbc..177742435e52 (15 commits) (flutter/engine#5963)
9d1e673 Temporarily add travis/analyze.sh back for Chrome bot (flutter/engine#5961)
4386afd Roll src/third_party/skia e6d0618f677c..36216fb0acbc (11 commits) (flutter/engine#5960)
7cef3da Roll src/third_party/skia 01d9a344b575..e6d0618f677c (1 commits) (flutter/engine#5958)
ad82cb1 Roll src/third_party/skia fdf05f4ff4e9..01d9a344b575 (1 commits) (flutter/engine#5957)
6ea410c Revert "Roll Dart to 17b54c76ce9b945c6f013ad08c19268409c0694a (flutter/engine#5955)" (flutter#5956)
f20c58f Roll Dart to 17b54c76ce9b945c6f013ad08c19268409c0694a (flutter/engine#5955)
ed1938e Roll src/third_party/skia 641ac7daa81c..fdf05f4ff4e9 (3 commits) (flutter/engine#5953)
5f04e00 Remove travis directory (flutter/engine#5935)
5442c0a Revert "Updated background execution implementation for Android" (flutter/engine#5949)
a5215ce Add hasImplicitScrolling SemanticFlag and support in Android bridge (flutter/engine#5941)
4681351 Roll src/third_party/skia 6e487e67a3f3..641ac7daa81c (16 commits) (flutter/engine#5948)
bc885f3 Updated background execution implementation for Android
5770cbd Roll src/third_party/skia 12fb9cfeee07..6e487e67a3f3 (8 commits) (flutter/engine#5946)
f4464a8 Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
c6baaaf Replace acquire+release thread annotation with excludes (flutter/engine#5944)
63ede2e Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
97aea09 Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
aaf4a9a Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
liyuqian added a commit to flutter/flutter that referenced this pull request Aug 7, 2018
@liyuqian
Roll engine to 7f083e5 (#20310)
57d8930 
* Roll engine to 7f083e5

7f083e5 Don't implicitly fall through in switch statement (flutter/engine#5964)
c7ce6dd Apply translation to accessibility tree when in landscape (flutter/engine#5950)
aef94b7 Reland "Updated background execution implementation for Android" (flutter/engine#5954)
3421bca Roll src/third_party/skia 36216fb0acbc..177742435e52 (15 commits) (flutter/engine#5963)
9d1e673 Temporarily add travis/analyze.sh back for Chrome bot (flutter/engine#5961)
4386afd Roll src/third_party/skia e6d0618f677c..36216fb0acbc (11 commits) (flutter/engine#5960)
7cef3da Roll src/third_party/skia 01d9a344b575..e6d0618f677c (1 commits) (flutter/engine#5958)
ad82cb1 Roll src/third_party/skia fdf05f4ff4e9..01d9a344b575 (1 commits) (flutter/engine#5957)
6ea410c Revert "Roll Dart to 17b54c76ce9b945c6f013ad08c19268409c0694a (flutter/engine#5955)" (#5956)
f20c58f Roll Dart to 17b54c76ce9b945c6f013ad08c19268409c0694a (flutter/engine#5955)
ed1938e Roll src/third_party/skia 641ac7daa81c..fdf05f4ff4e9 (3 commits) (flutter/engine#5953)
5f04e00 Remove travis directory (flutter/engine#5935)
5442c0a Revert "Updated background execution implementation for Android" (flutter/engine#5949)
a5215ce Add hasImplicitScrolling SemanticFlag and support in Android bridge (flutter/engine#5941)
4681351 Roll src/third_party/skia 6e487e67a3f3..641ac7daa81c (16 commits) (flutter/engine#5948)
bc885f3 Updated background execution implementation for Android
5770cbd Roll src/third_party/skia 12fb9cfeee07..6e487e67a3f3 (8 commits) (flutter/engine#5946)
f4464a8 Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
c6baaaf Replace acquire+release thread annotation with excludes (flutter/engine#5944)
63ede2e Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
97aea09 Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
aaf4a9a Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)

* Sync framework changes
@xster xster mentioned this pull request Dec 20, 2018
Open
@cbracken cbracken mentioned this pull request Mar 5, 2019
Merged
cbracken added a commit that referenced this pull request Mar 5, 2019
@cbracken
Add missing kHasImplicitScrolling enum value (#8030)
ed628da 
This brings the Dart and C++ semantics flag enums back in sync.

In #5941, implicit scrolling support was added to SemanticsFlag in
dart:ui, and to the Android embedder, but not to the SemanticsFlags enum
on the C++ side.

This also clarifies/corrects the documentation for this value in dart:ui
and in the embedder API.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @jason-simmons @googlebot