This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] disable Adreno 630 vulkan and add mechanism for android driver denylisting. #54920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iver denylisting.
chinmaygarde
approved these changes
Sep 3, 2024
| #include "impeller/renderer/backend/vulkan/driver_info_vk.h" | ||
| #include "impeller/renderer/backend/vulkan/surface_context_vk.h" | ||
| #include "impeller/renderer/backend/vulkan/test/mock_vulkan.h" | ||
| #include "third_party/swiftshader/include/vulkan/vulkan_core.h" |
Member
There was a problem hiding this comment.
Both this one and the next are bad includes. vk.h should suffice and sets up the right defines before import.
Perhaps the IDE is including it?
| /// Non functional Vulkan driver, see: | ||
| /// https://github.com/flutter/flutter/issues/154103 | ||
| /// | ||
| /// Reports "VK_INCOMPLETE" when compiling certain entity shader with |
Member
There was a problem hiding this comment.
Do we know which shader this is? I'll try to follow up.
We can catch up afterwards about this. Not blocking.
Contributor
Author
There was a problem hiding this comment.
Porterduff and conical gradient ssbo
| FML_LOG(IMPORTANT) << "Using the Impeller rendering backend (Vulkan)."; | ||
| } | ||
| } | ||
| if (context->GetDriverInfo()->IsKnownBadDriver()) { |
Member
There was a problem hiding this comment.
Perhaps an INFO log saying this happened? Or will this cause issues with tests further down the line?
Contributor
Author
There was a problem hiding this comment.
How would that log be actionable?
Member
There was a problem hiding this comment.
To the end user, it won't. But perhaps useful to know for us when we expect Vulkan but get OpenGL.
added 2 commits
September 3, 2024 10:56
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2024
…android driver denylisting. (flutter/engine#54920)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 3, 2024
…154581) flutter/engine@872cbe8...e042202 2024-09-03 [email protected] Roll Skia from 5515c08c2e44 to 0d9333e72a39 (8 revisions) (flutter/engine#54944) 2024-09-03 [email protected] [Impeller] disable Adreno 630 vulkan and add mechanism for android driver denylisting. (flutter/engine#54920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
reviewed
Sep 4, 2024
| FML_LOG(IMPORTANT) << "Using the Impeller rendering backend (Vulkan)."; | ||
| } | ||
| } | ||
| if (context->GetDriverInfo()->IsKnownBadDriver()) { |
Member
There was a problem hiding this comment.
Do you need a null check on context here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#154103
From local testing, the Adreno 630 returns VK_INCOMPLETE when compiling certain shaders with no other error messages. That is not a valid return code from vkCreateGraphicsPipeline and likely indicates severe problems with the driver.