This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] opt into exp canvas. #54913
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
97160d4
[Impeller] opt into exp canvas.
dd06f92
++
5181dd1
++
9468843
[impeller] fixes for subpass skipping.
e2f5268
++
d198704
better default.
0292df8
fix offset alignment.
bf7a396
++
08f6361
++
c85e2b4
++
df4e5e5
++
b894059
adjust flush location.
f50102e
++
be9be26
back to old clip stack.
06cbda0
use dcheck
1c0c46c
++
c168b96
++
69884f9
++
eb2bd85
Merge branch 'main' into back_to_exp_canvas
4248520
round out differences.
3938253
round in vs round out.
90e2eb3
Merge branch 'back_to_exp_canvas' of github.com:jonahwilliams/engine …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks OK. We might fail to trigger on some ops that don't use MF if an MF is accidentally set, but we won't get spurious failures at least. In the long run I actually think we want to consolidate the depth accounting in Impeller. We need to do a pre-pass to manage the text cache and to plan the ordering of ops, so we could just as easily compute depths as well during that phase. Then the accounting is all in (basically) one class where it can't get out of synch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not a bad idea, plus if we do any sort of sorting we'll have a prepass anyway - and the text cache isn't going away anytime soon.