Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable impeller cmake test until it is fixed #54788

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 26, 2024

This task is consistently failing (with 3 retries for every engine commit). There is an issue to fix the problem, but until that issue is addressed, the task is primarily wasting CI resources.

@flar flar requested review from zanderso and bdero August 26, 2024 20:50
@flar
Copy link
Contributor Author

flar commented Aug 26, 2024

See flutter/flutter#150870

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
Copy link
Contributor

auto-submit bot commented Aug 26, 2024

auto label is removed for flutter/engine/54788, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit d17f0cb into flutter:main Aug 26, 2024
37 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 27, 2024
…154172)

flutter/engine@b41ca79...7d751ac

2024-08-27 [email protected] Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799)
2024-08-27 [email protected] Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800)
2024-08-27 [email protected] Store a set of layers per view. (flutter/engine#54793)
2024-08-27 [email protected] Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798)
2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797)
2024-08-27 [email protected] Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795)
2024-08-27 [email protected] Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768)
2024-08-27 [email protected] Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792)
2024-08-26 [email protected] Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790)
2024-08-26 [email protected] Disable impeller cmake test until it is fixed (flutter/engine#54788)
2024-08-26 [email protected] macOS: Add @available check at macOS 12 workaround (flutter/engine#54784)
2024-08-26 [email protected] Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789)
2024-08-26 [email protected] macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#154172)

flutter/engine@b41ca79...7d751ac

2024-08-27 [email protected] Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799)
2024-08-27 [email protected] Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800)
2024-08-27 [email protected] Store a set of layers per view. (flutter/engine#54793)
2024-08-27 [email protected] Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798)
2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797)
2024-08-27 [email protected] Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795)
2024-08-27 [email protected] Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768)
2024-08-27 [email protected] Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792)
2024-08-26 [email protected] Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790)
2024-08-26 [email protected] Disable impeller cmake test until it is fixed (flutter/engine#54788)
2024-08-26 [email protected] macOS: Add @available check at macOS 12 workaround (flutter/engine#54784)
2024-08-26 [email protected] Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789)
2024-08-26 [email protected] macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants