This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] Delete unused create_ios_framework.py #54227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is unused and is superseded by create_full_ios_framework.py.
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2024
…152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 [email protected] [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 [email protected] Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 [email protected] [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 [email protected] Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 [email protected] Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 [email protected] [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 [email protected] Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 [email protected] [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 [email protected] Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 [email protected] Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 10, 2024
This renames the iOS framework creation script for consistency with the analogous macOS script. Previously, we had two iOS framework creation scripts: * create_ios_framework.py * create_full_ios_framework.py The former was unused and was deleted in #54227. The addition of "full" is no longer necessary to differentiate the two. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152583) flutter/engine@a4b88a3...08f9be3 2024-07-30 [email protected] [iOS] Delete unused create_ios_framework.py (flutter/engine#54227) 2024-07-30 [email protected] Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 2024-07-30 [email protected] [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 2024-07-30 [email protected] Do not disable partial repaint based on thread merging state (flutter/engine#54219) 2024-07-30 [email protected] Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is unused and is superseded by create_full_ios_framework.py.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.