Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update tests to Xcode 15 and iOS 17 simulator #49833

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

vashworth
Copy link
Contributor

Engine part of flutter/flutter#132237.

Also, fixes flutter/flutter#125227.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth
Copy link
Contributor Author

Linux mac_unopt was failing on an infra issue: flutter/flutter#141708

@vashworth vashworth marked this pull request as ready for review January 17, 2024 23:11
@vashworth vashworth requested a review from jmagman January 17, 2024 23:12
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2024
@auto-submit auto-submit bot merged commit d80fe1c into flutter:main Jan 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 18, 2024
…141785)

flutter/engine@b75d6d8...d80fe1c

2024-01-18 [email protected] Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833)
2024-01-18 [email protected] Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update iOS engine scenario goldens to work with iOS 16.2 simulator
2 participants