This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. #49076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bdero
force-pushed
the
bdero/local-bounds-fix
branch
from
be75fc9 to
53cb037
Compare
Contributor
|
Here is similar code in the DisplayListBuilder for reference: engine/display_list/dl_builder.cc Line 548 in 91f65ee engine/display_list/dl_builder.cc Line 420 in 91f65ee |
flar
approved these changes
Dec 15, 2023
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
LGTM.
Safe, but we should look at some more optimum solutions at some point.
| // applied. | ||
| // See also: https://github.com/flutter/flutter/issues/139294 | ||
| if (paint.image_filter) { | ||
| transform_stack_.back().cull_rect = std::nullopt; |
Contributor
There was a problem hiding this comment.
Another technique could be to run the current cull_rect through the filter to get a reverse bounds, as in:
Contributor
There was a problem hiding this comment.
Another optimization would be to see if the filter modifies location at all. The ColorFilterImageFilter would not need to clear the cull_rect, for instance.
Member
Author
There was a problem hiding this comment.
I don't think that's quite enough. In order to produce a correct cull rect, wouldn't we need to pass each new clip's bounds through the chain of all parent filters? Also, it would need to be forward bounds, not reverse, since the cull rect needs to expand for kernel filters.
Am I missing something?
Contributor
There was a problem hiding this comment.
It is done for each filter on each restore:
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2023
…140255) flutter/engine@6e3a048...ca329dd 2023-12-15 [email protected] [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter/engine#49076) 2023-12-15 [email protected] Roll Skia from cf84bab13da3 to 191943f9c43e (1 revision) (flutter/engine#49105) 2023-12-15 [email protected] Roll Dart SDK from e6528d1b7997 to d66f9c854db7 (1 revision) (flutter/engine#49104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 18, 2023
…utter#49076) We use this bounds rect for querying the DisplayList rtree when culling. But when sub-DisplayLists are being dispatched, the DisplayList's rtree is local and doesn't incorporate parent layer filters. So sub-DisplayLists are getting culled as if no filters are being applied. Technically our local bounds tracking in Aiks is actually correct here, but this is a quick fix to alleviate the problem. I don't know what the best longterm solution for this is. (cherry picked from commit ca329dd)
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 18, 2023
…utter#49076) We use this bounds rect for querying the DisplayList rtree when culling. But when sub-DisplayLists are being dispatched, the DisplayList's rtree is local and doesn't incorporate parent layer filters. So sub-DisplayLists are getting culled as if no filters are being applied. Technically our local bounds tracking in Aiks is actually correct here, but this is a quick fix to alleviate the problem. I don't know what the best longterm solution for this is. (cherry picked from commit ca329dd)
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
#49198) Cherry-pick for #49076. For issue: flutter/flutter#139294
bryanoltman
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jan 2, 2024
* [CP] Fix _availability_version_check for iOS 11 and 12 (flutter#48926) CP of flutter@5587d26 into 3.16 for flutter/flutter#138711. * [CP] [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter#49198) Cherry-pick for flutter#49076. For issue: flutter/flutter#139294 * [CP] Fix for AnimatedOpacity affects blended color overlay render (flutter#49190) This PR cherry-picks the following two commits: flutter@2dbc5d2 flutter@0b0fab8 to address flutter/flutter#139571 * [cherrypick-stable]Skip unexpected events in MultiPlatformViewBackgroundForegroundScenar… (flutter#49247) â�¦io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0 --------- Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
May 5, 2024
…. (#49198) Cherry-pick for flutter/engine#49076. For issue: flutter/flutter#139294
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#139294.
We use this bounds rect for querying the DisplayList rtree when culling. But when sub-DisplayLists are being dispatched, the DisplayList's rtree is local and doesn't incorporate parent layer filters. So sub-DisplayLists are getting culled as if no filters are being applied.
Technically our local bounds tracking in Aiks is actually correct here, but this is a quick fix to alleviate the problem. I don't know what the best longterm solution for this is.