Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Sort AiksTests into category namespaces #49008

Closed
wants to merge 4 commits into from

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Dec 14, 2023

issue flutter/flutter#140106

This pulls out the following groups:

  • gradients
  • images
  • pictures
  • text
  • clips
  • paths
  • unsorted

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke changed the title [Impeller] Sort aiks unittests [Impeller] Sort AiksTests into category namespaces Dec 14, 2023
@gaaclarke
Copy link
Member Author

@matanlurey please give this a look. It isn't perfect but I think this will put us in a better spot than where we are today. I'll pull out a couple more groups tomorrow. This thing will be a pain to land since this file changes a lot (all the more reason to split it up at some point).

@matanlurey
Copy link
Contributor

Supportive as an intermediate step.

My only ask (I can take a closer look tomorrow, EOD for me) is to add a header to the file explaining what the convention is if it will stay in this state for some time. Thanks for giving this a go!

@gaaclarke
Copy link
Member Author

closing in lieu of the approach in #49050

@gaaclarke
Copy link
Member Author

I found a better way to do this

@gaaclarke gaaclarke closed this Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants