Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Use #pragma once #48955

Closed
wants to merge 1 commit into from

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Dec 12, 2023

Updates non-public Windows files to use #pragma once instead of header guards.

In the future #48903 might be used to enforce this.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @matanlurey

This is the opposite direction that we're moving for the impeller subfolder. We should discuss what approach the repo needs to take and make sure that we're consistent.

@matanlurey
Copy link
Contributor

Thanks Jonah. Right, Loic, there isn't an obvious option here, but to avoid wasting more time we've decided to just enforce the LLVM-style header guards (as noted in the Google C++ style guide).

@loic-sharma
Copy link
Member Author

Ah gotcha, thank you all for the feedback. I'll close this then 😓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants