This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix framebuffer blend UVs. #46489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/fix-framebuffer-blend-transform
branch
from
30c15f3 to
63372d2
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
approved these changes
Oct 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2023
…135923) flutter/engine@db168be...1656dc4 2023-10-03 [email protected] Roll Skia from 3a227c225839 to 22d1ae035048 (1 revision) (flutter/engine#46513) 2023-10-03 [email protected] [Impeller] Fix framebuffer blend UVs. (flutter/engine#46489) 2023-10-03 [email protected] Roll Skia from cb4cfa571393 to 3a227c225839 (3 revisions) (flutter/engine#46511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135923) flutter/engine@db168be...1656dc4 2023-10-03 [email protected] Roll Skia from 3a227c225839 to 22d1ae035048 (1 revision) (flutter/engine#46513) 2023-10-03 [email protected] [Impeller] Fix framebuffer blend UVs. (flutter/engine#46489) 2023-10-03 [email protected] Roll Skia from cb4cfa571393 to 3a227c225839 (3 revisions) (flutter/engine#46511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
pushed a commit
to jonahwilliams/engine
that referenced
this pull request
Oct 11, 2023
Fixes b/303120488. There's no need to use the `GetCoverageUVs` utility in this case. Correct usage here would require the geometry to match the coverage rectangle of the snapshot in pass space with no further transformations to the geometry. We should just render the snapshot texture as-is with simple 0/1 UVs and the snapshot's transform.
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Fixes b/303120488. There's no need to use the `GetCoverageUVs` utility in this case. Correct usage here would require the geometry to match the coverage rectangle of the snapshot in pass space with no further transformations to the geometry. We should just render the snapshot texture as-is with simple 0/1 UVs and the snapshot's transform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/303120488.
There's no need to use the
GetCoverageUVsutility in this case. Correct usage here would require the geometry to match the coverage rectangle of the snapshot in pass space with no further transformations to the geometry.We should just render the snapshot texture as-is with simple 0/1 UVs and the snapshot's transform.
Before:
Screen.Recording.2023-10-02.at.9.09.25.PM.mov
After:
Screen.Recording.2023-10-02.at.8.28.50.PM.mov