Check whether the lookup of android.hardware.HardwareBuffer found a class

[jason-simmons]

No description provided.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[eyebrowsoffire]

LGTM

[jason-simmons]

One of the Firebase hosted test scenarios was still failing with this PR.

On the Firebase griffin-24-en-portrait device the FindClass("android/hardware/HardwareBuffer") call was returning success even though this is an API level 24 device. The GetMethodID("close") call would then throw an exception.

The Firebase test passes with this change:

  if (!g_hardware_buffer_class->is_null()) {
    g_hardware_buffer_close_method =
        env->GetMethodID(g_hardware_buffer_class->obj(), "close", "()V");
  }
  if (g_hardware_buffer_close_method == nullptr) {
    FML_LOG(WARNING)
        << "Could not locate android.hardware.HardwareBuffer class";
    // Continue on as this class may not exist at API <= 26.
    fml::jni::ClearException(env);
  }

@johnmccutchan