This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Search Web to selection controls on iOS #43324
Merged
auto-submit
merged 11 commits into
flutter:main
from
LouiseHsu:add-searchweb-to-selection-controls
Aug 2, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea76eb3
initial working prototype
LouiseHsu 29474dc
Merge branch 'main' of github.com:flutter/engine into add-searchweb-t…
LouiseHsu a6a6ae4
small refactor + add test
LouiseHsu 575892a
formatting
LouiseHsu c3fbd6a
Merge branch 'main' into add-searchweb-to-selection-controls
LouiseHsu a69b9d9
merge conflict
LouiseHsu 25976df
rewrite test, clean up
LouiseHsu 6202c94
formatting
LouiseHsu 26e3ad2
Merge branch 'add-searchweb-to-selection-controls' of github.com:loui…
LouiseHsu 7ec0371
remove extraneous return value
LouiseHsu 1e3f0f5
Merge branch 'main' into add-searchweb-to-selection-controls
LouiseHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe you could also try testing that a string with some characters that need to be escaped get escaped? If you think it's useful.