This repository was archived by the owner on Feb 25, 2025. It is now read-only.
switch from MockCanvas to DisplayListBuilder in layer unit tests #41889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2023
…126468) flutter/engine@10ac36c...406b354 2023-05-10 [email protected] [web] Re-enable history tests on Safari (flutter/engine#41901) 2023-05-10 [email protected] switch from MockCanvas to DisplayListBuilder in layer unit tests (flutter/engine#41889) 2023-05-10 [email protected] Revert "Move linux fuchsia engine v2 build to prod." (flutter/engine#41902) 2023-05-10 [email protected] Migrate mac host clang tidy to engine v2. (flutter/engine#41824) 2023-05-10 [email protected] [Impeller] delete special handling of RRect. (flutter/engine#41872) 2023-05-10 [email protected] Roll Fuchsia Mac SDK from JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898) 2023-05-10 [email protected] Only register top level window message listener upon registering service binding (flutter/engine#41733) 2023-05-10 [email protected] Roll Skia from 8c936fb9ba8e to 32f4cfc2460b (27 revisions) (flutter/engine#41891) 2023-05-10 [email protected] [web] dialog a11y fixes (flutter/engine#41681) 2023-05-10 [email protected] Roll Dart SDK from 2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882) 2023-05-10 [email protected] [Impeller] Increase minimum size of alpha glyph atlas. (flutter/engine#41880) 2023-05-10 [email protected] [Impeller] Use separate atlases and shaders for color and alpha (flutter/engine#41780) 2023-05-10 [email protected] Move linux fuchsia engine v2 build to prod. (flutter/engine#41865) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126468) flutter/engine@10ac36c...406b354 2023-05-10 [email protected] [web] Re-enable history tests on Safari (flutter/engine#41901) 2023-05-10 [email protected] switch from MockCanvas to DisplayListBuilder in layer unit tests (flutter/engine#41889) 2023-05-10 [email protected] Revert "Move linux fuchsia engine v2 build to prod." (flutter/engine#41902) 2023-05-10 [email protected] Migrate mac host clang tidy to engine v2. (flutter/engine#41824) 2023-05-10 [email protected] [Impeller] delete special handling of RRect. (flutter/engine#41872) 2023-05-10 [email protected] Roll Fuchsia Mac SDK from JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898) 2023-05-10 [email protected] Only register top level window message listener upon registering service binding (flutter/engine#41733) 2023-05-10 [email protected] Roll Skia from 8c936fb9ba8e to 32f4cfc2460b (27 revisions) (flutter/engine#41891) 2023-05-10 [email protected] [web] dialog a11y fixes (flutter/engine#41681) 2023-05-10 [email protected] Roll Dart SDK from 2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882) 2023-05-10 [email protected] [Impeller] Increase minimum size of alpha glyph atlas. (flutter/engine#41880) 2023-05-10 [email protected] [Impeller] Use separate atlases and shaders for color and alpha (flutter/engine#41780) 2023-05-10 [email protected] Move linux fuchsia engine v2 build to prod. (flutter/engine#41865) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an ongoing set of efforts to address flutter/flutter#106448
The layer unittests have been using a MockCanvas class to record the painting of trees of layers and then testing for the expected output.
A while back a similar mechanism was created to compare DisplayList output and to print out a human-friendly version of the differences found, but it was only used in a few tests written at the time it was created and a few since then.
This is the first in a series of PRs that will move all the rest of the unit tests onto the new DL comparison mechanism, starting with the layer types that just do basic drawing. Some of the remaining layers will require creating new hooks in, for instance, the Texture registry, the performance overlay TextBlob generation, etc.