Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Don't include end-of-line characters in line boundary #39693

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[web] Don't include end-of-line characters in line boundary #39693

merged 2 commits into from
Feb 17, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 16, 2023

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 16, 2023
yjbanov
yjbanov approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Renzo-Olivares
Renzo-Olivares approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

Looks like one of the framework tests is failing, but that might be because of a workaround for this very issue https://github.com/flutter/flutter/blob/9fcaaebb5279dd8a682304a7d742c224c1ba17f2/packages/flutter/test/rendering/paragraph_test.dart#L1063

@mdebbar mdebbar mentioned this pull request Feb 17, 2023
Merged
@mdebbar
Copy link
Contributor Author

mdebbar commented Feb 17, 2023

LGTM! Thanks for fixing this!

Looks like one of the framework tests is failing, but that might be because of a workaround for this very issue https://github.com/flutter/flutter/blob/9fcaaebb5279dd8a682304a7d742c224c1ba17f2/packages/flutter/test/rendering/paragraph_test.dart#L1063

Right! I created a framework PR to temporarily disable a few expects while I land this engine PR. Here's the framework PR: flutter/flutter#121005 (PTAL).

@mdebbar mdebbar mentioned this pull request Feb 17, 2023
Merged
@Renzo-Olivares Renzo-Olivares mentioned this pull request Feb 17, 2023
Merged
8 tasks
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023
@auto-submit auto-submit bot merged commit a37e27b into flutter:main Feb 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
a37e27b77 [web] Don't include end-of-line characters in line boundary (…
8e83739 
…flutter/engine#39693)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 2b2780185dd5 to a37e27b77008 (2 revisions) (#…
0fa6527 
…121020)

* 1d7f0c66c Integrate ios_engine debug, profile and release. (flutter/engine#39724)

* a37e27b77 [web] Don't include end-of-line characters in line boundary (flutter/engine#39693)
@mdebbar mdebbar deleted the line_boundary branch June 22, 2023 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@yjbanov yjbanov yjbanov approved these changes

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextPainter.getLineBoundary returns the wrong value when run on web tests
3 participants
@mdebbar @yjbanov @Renzo-Olivares