This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use SkImageFilters::Shader instead of ::Paint #37682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkImageFilters::Paint() is deprecated and will be removed in https://skia-review.googlesource.com/c/skia/+/604917
jason-simmons
approved these changes
Nov 16, 2022
jason-simmons
added
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37682, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37682, due to Validations Fail. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
…115495) * 62571900b Roll Skia from 74a57221dfb3 to 1dfecd7cd478 (6 revisions) (flutter/engine#37685) * 35ecb2bf4 Use SkImageFilters::Shader instead of ::Paint (flutter/engine#37682)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115495) * 62571900b Roll Skia from 74a57221dfb3 to 1dfecd7cd478 (6 revisions) (flutter/engine#37685) * 35ecb2bf4 Use SkImageFilters::Shader instead of ::Paint (flutter/engine#37682)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115495) * 62571900b Roll Skia from 74a57221dfb3 to 1dfecd7cd478 (6 revisions) (flutter/engine#37685) * 35ecb2bf4 Use SkImageFilters::Shader instead of ::Paint (flutter/engine#37682)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkImageFilters::Paint() is deprecated and will be removed in https://skia-review.googlesource.com/c/skia/+/604917.
These unit tests are the last known usage of ::Paint(), but since they are just solid colors, the migration is very straightforward to switch to SkShader::Color().
https://bugs.chromium.org/p/skia/issues/detail?id=13927
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.