Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iPhone floating cursor selection #36643

Merged
merged 12 commits into from
May 11, 2023
Merged

iPhone floating cursor selection #36643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3b7bc17
iPhone software keyboard selection gesture
moffatman Oct 6, 2022
582c3f8
Address some feedback
moffatman Oct 20, 2022
48fd022
Consider _selectionAffinity
moffatman Dec 8, 2022
b7e47ca
Rewrite for RTL handling
moffatman Dec 21, 2022
b73ae4d
Put the caret rect exactly on the edge
moffatman Feb 3, 2023
031a6cc
Reduce vertical precision
moffatman Feb 3, 2023
6872853
Add affinity to FlutterTextPosition
moffatman Apr 28, 2023
2573435
Address feedback
moffatman Apr 29, 2023
5725902
Fix test failures
moffatman Apr 30, 2023
d2ceb76
Some renames for clarity
moffatman May 2, 2023
9d8d65f
Simplify rect comparison function
moffatman May 3, 2023
58bd8ed
Put the loop back
moffatman May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ typedef NS_ENUM(NSInteger, FlutterScribbleInteractionStatus) {
@interface FlutterTextPosition : UITextPosition

@property(nonatomic, readonly) NSUInteger index;
@property(nonatomic, readonly) UITextStorageDirection affinity;

+ (instancetype)positionWithIndex:(NSUInteger)index;
- (instancetype)initWithIndex:(NSUInteger)index;
+ (instancetype)positionWithIndex:(NSUInteger)index affinity:(UITextStorageDirection)affinity;
- (instancetype)initWithIndex:(NSUInteger)index affinity:(UITextStorageDirection)affinity;

@end

Expand Down Expand Up @@ -100,6 +102,10 @@ typedef NS_ENUM(NSInteger, FlutterScribbleInteractionStatus) {

+ (instancetype)selectionRectWithRect:(CGRect)rect position:(NSUInteger)position;

+ (instancetype)selectionRectWithRect:(CGRect)rect
position:(NSUInteger)position
writingDirection:(NSWritingDirection)writingDirection;

- (instancetype)initWithRectAndInfo:(CGRect)rect
position:(NSUInteger)position
writingDirection:(NSWritingDirection)writingDirection
Expand All @@ -108,6 +114,8 @@ typedef NS_ENUM(NSInteger, FlutterScribbleInteractionStatus) {
isVertical:(BOOL)isVertical;

- (instancetype)init NS_UNAVAILABLE;

- (BOOL)isRTL;
@end

API_AVAILABLE(ios(13.0)) @interface FlutterTextPlaceholder : UITextPlaceholder
Expand Down
Loading