Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add a temporary target to help with the migration to gn artifacts. #34049

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Add a temporary target to help with the migration to gn artifacts. #34049

merged 1 commit into from
Jun 15, 2022

Conversation

godofredoc
Copy link
Contributor

We'll save the file to the new and old locations while we transition from recipes generated artifacts to gn generated ones. Once we finish that implementation we will start standardizing artifact names and locations.

Bug: flutter/flutter#105351

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add a temporary target to help with the migration to gn artifacts.
d7cd0d1 
We'll save the file to the new and old locations while we transition
from recipes generated artifacts to gn generated ones. Once we finish
that implementation we will start standardizing artifact names and locations.

Bug: flutter/flutter#105351
@godofredoc godofredoc changed the title Add a temporary target to help with the migration to gn artifacs. Add a temporary target to help with the migration to gn artifacts. Jun 15, 2022
christopherfujino
christopherfujino approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2022
@auto-submit auto-submit bot merged commit 68f11fa into main Jun 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
c245ad2 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
445bbbb 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
91feb82 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
2c639e2 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
a16d7ef 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
4b26e80 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
49db909 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
dad7fee 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
5a14c4a 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
e5f4910 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
b85c995 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
e52c114 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
c1b4b88 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
3af23f1 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
cf22d41 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
470b484 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
a6b740d 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
813526b 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
53d3a8e 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
7768f91 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
e70baca 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
e1a4c8b 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
87702db 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
f81f417 
…acts. (flutter/engine#34049)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
68f11fa Add a temporary target to help with the migration to gn artif…
5ee42a1 
…acts. (flutter/engine#34049)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@godofredoc @houhuayong
Add a temporary target to help with the migration to gn artifacts. (f…
0f97ce3 
…lutter#34049)
@chinmaygarde chinmaygarde deleted the add_tmp_target branch July 6, 2022 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @christopherfujino