Remove logcat flush #33809
Remove logcat flush #33809
Conversation
|
Gold has detected about 4 new digest(s) on patchset 1. |
| await step('Flush logcat...', () async { | ||
| await logcat.flush(); | ||
| }); | ||
|
|
||
| exit(0); |
There was a problem hiding this comment.
This seems not quite right to me - can we instead remove sink from the pipe and then flush?
|
Why is this changing the goldens that much? |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
It's http://b234791343 again, and https://flutter-review.googlesource.com/c/recipes/+/30888 didn't land for some reason |
|
Text that wasn't showing up before is showing up now - are we not stopping at a deterministic point in rendering? |
|
Hm, now it all looks like the pixel launcher thing again. This is going to cause a lot of noise on PRs being landed that see this flip around and don't understand why... |
|
From triage: We don't believe this is the right fix. But lets wait for @blasten to be back to discuss further. |
IOSink.flushcannot be called while a write operation is happening.It also doesn't seem like
flushactually flushes the bytes to disk.For context dart-lang/sdk#25277 (comment)
Fixes https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8812362342732992161/+/u/Scenario_App_Integration_Tests/stdout?format=raw