Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@blasten
Copy link

@blasten blasten commented Mar 19, 2022

Fixes http://b/225327795

PlatformView#getView() is nullable

@blasten blasten marked this pull request as ready for review March 19, 2022 01:03
@blasten blasten requested a review from jason-simmons March 19, 2022 01:03
Copy link
Member

@hamdikahloun hamdikahloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@blasten Can you update the issue link please

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 19, 2022
@fluttergithubbot fluttergithubbot merged commit 8dc7cd1 into flutter:main Mar 19, 2022
@blasten
Copy link
Author

blasten commented Mar 19, 2022

Thanks for the review.

The issue is described in the PR description:
PlatformView#getView() is nullable, so any code that depends on it must check for null.

@hamdikahloun
Copy link
Member

Link not working

Fixes http://b/225327795

@blasten
Copy link
Author

blasten commented Mar 19, 2022

This is an internal link, but the issue is what is described in the PR description

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants