Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@moffatman
Copy link
Contributor

Original PR was #28571
Reverted in #31375
Should be acceptable now thanks to flutter/flutter#98202

This commit adds support to the engine core for encoding trackpad gestures for to the framework. This covers zoom, rotate, and pan gestures. The changes to send trackpad gestures from each platform will come in follow-up PRs.

  1. New types of PointerChange: panZoomStart, panZoomUpdate, panZoomEnd
  2. New fields on PointerData to handle two-finger trackpad gesture fields (panX, panY, scale, rotation)

Design Document

Framework PR: flutter/flutter#89944

Addresses flutter/flutter#23604

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android platform-fuchsia platform-ios platform-web Code specifically for the web engine labels Feb 11, 2022
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt requested a review from goderbauer February 11, 2022 21:54
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM assuming no changes since the previous PR to this code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

embedder Related to the embedder API platform-android platform-fuchsia platform-ios platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants