Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Change support for VM service message from "The Dart VM Service is listening" to "The Dart VM service is listening" #31361

Merged
bkonyi merged 1 commit into from
Feb 10, 2022
Merged

Change support for VM service message from "The Dart VM Service is listening" to "The Dart VM service is listening" #31361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/runtime/dart/utils/vmservice_object.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void VMServiceObject::GetContents(LazyEntryVector* out_vector) const {
std::vector<std::string> files;
if (!ReadDirContents(kPortDir, &files)) {
FX_LOGF(ERROR, LOG_TAG,
"Failed to read Dart VM Service port directory '%s': %s", kPortDir,
"Failed to read Dart VM service port directory '%s': %s", kPortDir,
Copy link
Member

@jason-simmons jason-simmons Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Contributor Author

@bkonyi bkonyi Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, it's more consistent...? :-) In all actuality, I just did s/Dart VM Service/Dart VM service/g on the repo. I can revert this file if you'd prefer?

strerror(errno));
return;
}
Expand Down
2 changes: 1 addition & 1 deletion shell/testing/observatory/launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ShellProcess {

Uri? _extractVMServiceUri(String str) {
final listeningMessageRegExp = RegExp(
r'(?:Observatory|The Dart VM Service is) listening on ((http|//)[a-zA-Z0-9:/=_\-\.\[\]]+)',
r'(?:Observatory|The Dart VM service is) listening on ((http|//)[a-zA-Z0-9:/=_\-\.\[\]]+)',
);
final match = listeningMessageRegExp.firstMatch(str);
if (match != null) {
Expand Down
2 changes: 1 addition & 1 deletion testing/android_systrace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def LaunchPackage(package_name, activity_name, adb_path='adb'):
'%s/%s' % (package_name, activity_name)], stderr=subprocess.STDOUT)
for line in logcat.stdout:
print('>>>>>>>> ' + line.strip())
if ('Observatory listening' in line) or ('Dart VM Service is listening' in line):
if ('Observatory listening' in line) or ('Dart VM service is listening' in line):
logcat.kill()
break

Expand Down