Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Improve documentation of Path.extendWithPath #27793

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

whesse
Copy link
Contributor

@whesse whesse commented Jul 29, 2021

The documentation used the word "segment" instead of "sub-path".
The documentation of Path.addPath described adding a Path as adding a single sub-path.

The documentation used the word "segment" instead of "sub-path".
The documentation of Path.addPath described adding a Path as adding a single sub-path.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@whesse
Copy link
Contributor Author

whesse commented Jul 29, 2021

The skia documentation for the function called by these dart:ui functions is at
https://api.skia.org/classSkPath.html#aeb3d46684dc291c166aa11de92ca903b

I have read the skia implementation to verify that it adds the lineTo, even to a closed sub-path.

@jonahwilliams jonahwilliams requested a review from Hixie July 31, 2021 02:05
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whesse whesse merged commit 49f4eaa into flutter:master Aug 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
The documentation used the word "segment" instead of "sub-path".
The documentation of Path.addPath described adding a Path as adding a single sub-path.
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
The documentation used the word "segment" instead of "sub-path".
The documentation of Path.addPath described adding a Path as adding a single sub-path.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants