This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
TimePoint::Now uses DartTimestampProvider #27737
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #include "flutter/fml/time/dart_timestamp_provider.h" | ||
|
|
||
| #include "dart_tools_api.h" | ||
|
|
||
| namespace fml { | ||
|
|
||
| DartTimestampProvider::DartTimestampProvider() = default; | ||
|
|
||
| DartTimestampProvider::~DartTimestampProvider() = default; | ||
|
|
||
| fml::TimePoint DartTimestampProvider::Now() { | ||
| return fml::TimePoint::FromTicks(Dart_TimelineGetTicks()); | ||
| } | ||
|
|
||
| fml::TimePoint DartTimelineTicksSinceEpoch() { | ||
| return DartTimestampProvider::Instance().Now(); | ||
| } | ||
|
|
||
| } // namespace fml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #ifndef FLUTTER_FML_TIME_DART_TIMESTAMP_PROVIDER_H_ | ||
| #define FLUTTER_FML_TIME_DART_TIMESTAMP_PROVIDER_H_ | ||
|
|
||
| #include "flutter/fml/time/timestamp_provider.h" | ||
|
|
||
| #include "flutter/fml/macros.h" | ||
| #include "flutter/fml/time/time_point.h" | ||
|
|
||
| namespace fml { | ||
|
|
||
| fml::TimePoint DartTimelineTicksSinceEpoch(); | ||
|
|
||
| /// TimestampProvider implementation that is backed by Dart_TimelineGetTicks | ||
| class DartTimestampProvider : TimestampProvider { | ||
| public: | ||
| static DartTimestampProvider& Instance() { | ||
| static DartTimestampProvider instance; | ||
| return instance; | ||
| } | ||
|
|
||
| ~DartTimestampProvider() override; | ||
|
|
||
| fml::TimePoint Now() override; | ||
|
|
||
| private: | ||
| DartTimestampProvider(); | ||
|
|
||
| FML_DISALLOW_COPY_AND_ASSIGN(DartTimestampProvider); | ||
| }; | ||
|
|
||
| } // namespace fml | ||
|
|
||
| #endif // FLUTTER_FML_TIME_DART_TIMESTAMP_PROVIDER_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I don't understand this API but this seems off to me. Here, we are depending on the timebases of
fml::TimePointandDart_Timelineto be identical. Looking at what was recently exposed we'd need to take into the timebase usingDart_TimelineGetTicksFrequency. Maybe we are getting away with these because both are in nanoseconds?