This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement Image.clone for CanvasKit #21555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Oct 2, 2020
| return RefCountedSkiaObjectBox._(wrapper, skObject, _refs); | ||
| } | ||
|
|
||
| /// Removes the reference count for the [skObject]. |
There was a problem hiding this comment.
"Removes the reference count" doesn't sound right. Maybe "Decrement the reference count" or "Remove this box from reference list"?
| /// | ||
| /// The [delete] method may be called any number of times. The box | ||
| /// will only delete the object once. | ||
| class RefCountedSkiaObjectBox extends SkiaObjectBox { |
There was a problem hiding this comment.
The image classes are the only users of SkiaObjectBox. Can we just make SkiaObjectBox ref-counted and not have two classes?
yjbanov
approved these changes
Oct 2, 2020
|
|
||
| CkAnimatedImage._(this._skAnimatedImage, SkiaObjectBox? boxToClone) { | ||
| if (boxToClone != null) { | ||
| box = boxToClone.clone(this); |
There was a problem hiding this comment.
Should we assert that the image in boxToClone and _skAnimatedImage are the same?
Alternatively, we could split this into two specialized constructors.
|
|
||
| CkImage._(this.skImage, SkiaObjectBox? boxToClone) { | ||
| if (boxToClone != null) { | ||
| box = boxToClone.clone(this); |
There was a problem hiding this comment.
same comment as in CkAnimatedImage.
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Oct 2, 2020
Changes since last time: - Test for CanvasKit image rendering (flutter#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311) This reverts commit 473358d.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
dnfield
added a commit
to flutter/flutter
that referenced
this pull request
Oct 5, 2020
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d.
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
Image.disposeandImage.cloneproperly so that flutter/flutter#67100 can be relanded.Creates a
RefCountedSkiaObjectBoxsubclass ofSkiaObjectBoxto support this.Related Issues
flutter/flutter#67100
flutter/flutter#66688
flutter/flutter#56482
#21057
Tests
I added the following tests:
Tests that
Image.disposeandImage.clone/Image.isCloneOfwork properly.Tests for
cloneand stacktrace functionality onRefCountedSkiaObjectBox.