-
Notifications
You must be signed in to change notification settings - Fork 6k
Writing the commit no to a text file #21546
Conversation
Nevermind, I can see that that recipe is scheduling the builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, you are right, that recipe invokes the flutter_drone.py for the shards :) |
hmmm the idea didn't worked. accessing environment using env['FLUTTER_REF'] didn't work. I'll update the PR once I find a solution: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/nurhan_google.com/8f6fab731fab383b8156b68f859f3175a916e13821ec2c8cb56bedd12502f008/+/annotations |
how about echoing to stdout and then grabbing that from the from the recipe? |
I tried echoing and the StepData (which consumes the echo to a json object). Using these methods prevent me from printing multiple things to the stdout such as the steps we run or the flutter version. So I implemented the other method we discussed (writing to a file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* setting an env variable using commit no * change variable name * try to use ref no as string * use echo for output * remove all the other stdout * echo json instead of only the commit no * use the file method * list the directory contents * remove pwd. print flutter version verbose
Writing the commit no to a text file. This will be used for ref number to send the drones in the web tests: https://devops-console-oss.corp.google.com/flutter/recipes/+/master:recipes/engine/web_engine_framework.py;l=137
I initially thought I can use one of the library calls to get the commit no we synced using the API. However I couldn't find a method for it.
other tried methods:
Usage inside the recipe: