Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@blasten
Copy link

@blasten blasten commented Aug 28, 2020

This reverts commit 4de62c7.

The fix is #20800

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 29, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 29, 2020
@blasten blasten force-pushed the reland_android_pv branch from bb2a35f to b18f482 Compare August 31, 2020 16:44
@blasten blasten merged commit 5e54c70 into flutter:master Aug 31, 2020
@blasten blasten deleted the reland_android_pv branch August 31, 2020 19:17
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864)

* 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)

* 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)

* c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910)

* 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)

* 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668)

* 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)

* d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)

* abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)

* 101316b [web] migrate from e2e to integration_test (flutter/engine#20914)

* 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)

* 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760)

* 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)

* a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)

* 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)

* 95f2b72 Create root isolate asynchronously (flutter/engine#20142)

* 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)

* a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)

* 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842)

* d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750)

* 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936)

* 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937)

* f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)

* 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)

* 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931)

* ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)

* 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)

* 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)

* d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)

* f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)

* 634e499 Use hint freed specifically for image disposal (flutter/engine#20754)

* c700479 Revert external size changes to Picture (flutter/engine#20950)

* 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)

* 80f4481 renaming e2e tests to integration (flutter/engine#20954)

* 61e057a Clear GL context before Gr context (flutter/engine#20957)

* f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)

* 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)

* efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965)

* 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)

* 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)

* 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)

* e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)
flar pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864)

* 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)

* 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)

* c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910)

* 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)

* 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668)

* 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)

* d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)

* abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)

* 101316b [web] migrate from e2e to integration_test (flutter/engine#20914)

* 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)

* 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760)

* 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)

* a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)

* 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)

* 95f2b72 Create root isolate asynchronously (flutter/engine#20142)

* 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)

* a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)

* 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842)

* d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750)

* 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936)

* 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937)

* f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)

* 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)

* 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931)

* ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)

* 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)

* 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)

* d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)

* f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)

* 634e499 Use hint freed specifically for image disposal (flutter/engine#20754)

* c700479 Revert external size changes to Picture (flutter/engine#20950)

* 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)

* 80f4481 renaming e2e tests to integration (flutter/engine#20954)

* 61e057a Clear GL context before Gr context (flutter/engine#20957)

* f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)

* 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)

* efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965)

* 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)

* 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)

* 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)

* e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)

* 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter/engine#20973)

* 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter/engine#20974)

* 3f05b52 Always set the callback during Rasterizer setup (flutter/engine#20976)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter/engine#20864)

* 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)

* 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)

* c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910)

* 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)

* 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668)

* 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)

* d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)

* abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)

* 101316b [web] migrate from e2e to integration_test (flutter/engine#20914)

* 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)

* 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760)

* 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)

* a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)

* 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)

* 95f2b72 Create root isolate asynchronously (flutter/engine#20142)

* 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)

* a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)

* 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842)

* d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter/engine#20750)

* 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter/engine#20936)

* 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter/engine#20937)

* f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)

* 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)

* 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931)

* ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)

* 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)

* 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)

* d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)

* f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)

* 634e499 Use hint freed specifically for image disposal (flutter/engine#20754)

* c700479 Revert external size changes to Picture (flutter/engine#20950)

* 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)

* 80f4481 renaming e2e tests to integration (flutter/engine#20954)

* 61e057a Clear GL context before Gr context (flutter/engine#20957)

* f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)

* 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)

* efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965)

* 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)

* 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)

* 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)

* e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter/engine#20864)

* 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)

* 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)

* c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910)

* 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)

* 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668)

* 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)

* d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)

* abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)

* 101316b [web] migrate from e2e to integration_test (flutter/engine#20914)

* 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)

* 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760)

* 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)

* a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)

* 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)

* 95f2b72 Create root isolate asynchronously (flutter/engine#20142)

* 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)

* a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)

* 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842)

* d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter/engine#20750)

* 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter/engine#20936)

* 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter/engine#20937)

* f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)

* 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)

* 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931)

* ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)

* 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)

* 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)

* d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)

* f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)

* 634e499 Use hint freed specifically for image disposal (flutter/engine#20754)

* c700479 Revert external size changes to Picture (flutter/engine#20950)

* 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)

* 80f4481 renaming e2e tests to integration (flutter/engine#20954)

* 61e057a Clear GL context before Gr context (flutter/engine#20957)

* f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)

* 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)

* efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965)

* 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)

* 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)

* 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)

* e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)

* 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter/engine#20973)

* 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter/engine#20974)

* 3f05b52 Always set the callback during Rasterizer setup (flutter/engine#20976)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants