-
Notifications
You must be signed in to change notification settings - Fork 6k
Document flutter::DartServiceIsolate. #17301
Document flutter::DartServiceIsolate. #17301
Conversation
|
Minor doc only change to land on red to unblock LUCI that is stuck on an infra flake. |
jason-simmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
runtime/dart_service_isolate.h
Outdated
| class DartServiceIsolate { | ||
| public: | ||
| //---------------------------------------------------------------------------- | ||
| /// The handle used to refer to callbacks registered with service isolate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "with the service isolate"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
runtime/dart_service_isolate.h
Outdated
| /// | ||
| /// @param[in] callback The callback with information about the observatory. | ||
| /// | ||
| /// @return A handle for the callback that can be used layer in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "later"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
1dc1468 to
3c64c81
Compare
No description provided.