This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove checks for the always true using_fuchsia_sdk flag in all GN files. #17261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
jason-simmons
approved these changes
Mar 23, 2020
…les. This flag was used as a temporary measure to make engine targets buildable in both the Fuchsia and Flutter buildroots. `using_fuchsia_sdk` would be set to true in Flutter because Flutter would be using the Fuchsia SDK to build Fuchsia artifacts. The Fuchsia buildroot would set the flag to false because it had its buildroot to build artifacts directly and didn’t need (or indeed have) and SDK. No functional change. Just a cleanup of dead build rules.
chinmaygarde
force-pushed
the
no_mo_using_fuchsia_sdk
branch
from
da0067f to
bc17cac
Compare
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was used as a temporary measure to make engine targets buildable in
both the Fuchsia and Flutter buildroots.
using_fuchsia_sdkwould be set totrue in Flutter because Flutter would be using the Fuchsia SDK to build Fuchsia
artifacts. The Fuchsia buildroot would set the flag to false because it had its
buildroot to build artifacts directly and didn’t need (or indeed have) and SDK.
No functional change. Just a cleanup of dead build rules.