Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[lsc] Remove fuchsia.net.SocketProvider #11316

Merged
merged 1 commit into from
Aug 21, 2019
Merged

[lsc] Remove fuchsia.net.SocketProvider #11316

merged 1 commit into from
Aug 21, 2019

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Aug 20, 2019

fuchsia.net.SocketProvider has been replaced with fuchsia.net.NameLookup
and fuchsia.posix.socket.Provider.

@cbracken this was done in topaz in https://fuchsia.googlesource.com/topaz/+/a54ab50efb6186b3d6f73f12ca6b2b83230bf615.

fuchsia.net.SocketProvider has been replaced with fuchsia.net.NameLookup
and fuchsia.posix.socket.Provider.
@chinmaygarde
Copy link
Member

cc @iskakaushik

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamird
Copy link
Contributor Author

tamird commented Aug 21, 2019

Can someone hit the merge?

@iskakaushik
Copy link
Contributor

@tamird I was waiting for the tree to be green.

@iskakaushik iskakaushik merged commit 29469f3 into flutter:master Aug 21, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 21, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 21, 2019
[email protected]:flutter/engine.git/compare/9f8b1d223ee8...29469f3

git log 9f8b1d2..29469f3 --no-merges --oneline
2019-08-21 [email protected] [lsc] Remove fuchsia.net.SocketProvider (flutter/engine#11316)
2019-08-21 [email protected] Roll src/third_party/skia f99b7960f433..80bff5b3a2d7 (2 commits) (flutter/engine#11343)
2019-08-21 [email protected] Remove engine hash from the output artifact (flutter/engine#11330)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants