-
Notifications
You must be signed in to change notification settings - Fork 345
Setting up package:unified_analytics
within devtools
#7084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eliasyishak
merged 38 commits into
flutter:master
from
eliasyishak:setup-unified-analytics
Feb 13, 2024
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
01b3c7e
Edits to case statements for unified_analytics
eliasyishak ecb9972
Update server_api.dart
eliasyishak 25e642a
Pass the consent message from the server to app
eliasyishak 786e79c
Hook function to confirm message has been shown
eliasyishak 38d78dd
Automatically onboard devtools if message shown
eliasyishak 32cfdd6
Update pubspec.yaml
eliasyishak 9f929fd
Format fix
eliasyishak a5c3528
`AnalyticsController. consentMessage` non-nullable
eliasyishak a7c3daa
Return null from `confirmConsentMessageShown`
eliasyishak cb8498d
Swap for `apiAnalyticsConsentMessageShown`
eliasyishak 013a5b7
Fixing build time errors for non-nullable strings
eliasyishak 22e3664
`get` --> `fetch` for methods getting consent msg
eliasyishak 70c9019
Format fix
eliasyishak 3120c4a
Remove unused parameter
eliasyishak 180e0fd
Merge remote-tracking branch 'upstream/master' into setup-unified-ana…
eliasyishak 37db4db
Fix test
eliasyishak 2a465a4
Merge remote-tracking branch 'upstream/master' into setup-unified-ana…
eliasyishak 4fed95b
Fix test to check that consent message is shown
eliasyishak 121dfa3
Update NEXT_RELEASE_NOTES.md
eliasyishak a9d1593
Use hyperlink to link to the policy page
eliasyishak 66c92fe
Dart format fix
eliasyishak aa16dfc
Handle errors when parsing the consent message
eliasyishak c39a9a4
Use stubbed function to get fake message
eliasyishak 60ecf83
`confirmConsentMessageShown` -> `markConsentMessageAsShown`
eliasyishak 0414bd8
Fix typo
eliasyishak a4230b1
Documentation added per code review
eliasyishak 02a07c3
Add analytics package to devtools_app
eliasyishak 06242fb
Have `Analytics` instance created in dds
eliasyishak ffc97d4
Merge branch 'master' into setup-unified-analytics
eliasyishak 905fed9
Fix merge errors
eliasyishak 97a1405
Merge remote-tracking branch 'upstream/master' into setup-unified-ana…
eliasyishak bbf2985
Fix nits from code review
eliasyishak db3bc4c
Use `LinkTextSpan` for url in consent message
eliasyishak 14ab72b
Merge remote-tracking branch 'upstream/master' into setup-unified-ana…
eliasyishak 0ea02df
Fix test
eliasyishak e77804a
`devtools_tool fix-goldens --run-id=7890083211`
eliasyishak 43738db
Revert "`devtools_tool fix-goldens --run-id=7890083211`"
eliasyishak 36eb36a
Merge remote-tracking branch 'upstream/master' into setup-unified-ana…
eliasyishak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"and to allow...". This part is a little confusing to me. What if the user has selected 'no thanks'? We still need to mark the consent message as shown right? But this makes it sound like this method not only marks the consent message as shown, but also opts in to analytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I made the decision to automatically mark the message as shown when we show the text. If the user was previously opted out through other dash tools, then they will remain opted out. If they press the accept button, we will change the their telemetry status to opted in for all dash tools.
But in both cases, marking the message as shown just tells the package to add it to the configuration file and log the date the message was shown