Skip to content

170476 Implementation of PR base expiration validation on specific branch only #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Oct 3, 2025
Merged

170476 Implementation of PR base expiration validation on specific branch only #4862

auto-submit merged 8 commits into from
Oct 3, 2025

Conversation

@ievdokdm
Copy link
Contributor

@ievdokdm ievdokdm commented Oct 2, 2025

Implemented logic to validate PR base expiration on specific branch only

require configuration change from:

base_commit_allowed_days: 7

to:

base_commit_expiration:
  branch: "main"
  allowed_days: 7

Issue: flutter/flutter#170476

@ievdokdm ievdokdm requested a review from jtmcdole October 2, 2025 19:55
jtmcdole
jtmcdole requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left.

We should have an issue filed to change all this yaml hand parsing to JsonSerializable.

@ievdokdm ievdokdm requested a review from jtmcdole October 3, 2025 22:41
jtmcdole
jtmcdole approved these changes Oct 3, 2025
View reviewed changes
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Oct 3, 2025
@auto-submit auto-submit bot merged commit 9d0362f into flutter:main Oct 3, 2025
16 checks passed
@jmagman jmagman mentioned this pull request Oct 6, 2025
Closed
4 tasks
@ievdokdm ievdokdm deleted the 170476_branch branch December 12, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ievdokdm @jtmcdole