feat(config): support dynamic config for cocoon #4645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we have to update secrets in cloud console; but it would be better to track some configs in git. The goal is to fetch (from HEAD) a checked in "config.json" and cache that between the services. Using json serializable allows us to sanity check the changes.
matanlurey
approved these changes
May 6, 2025
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
LGTM. A few comments.
- Make the dynamic config required - Make more things private (by pulling in the updater) - Update tests to use real config with fake secrets.
jtmcdole
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have to update secrets in cloud console; but it would be better to track some configs in git. The goal is to fetch (from HEAD) a checked in "config.json" and cache that between the services.
Using json serializable allows us to sanity check the changes.