This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add deprecation warnings when compiling Android engine #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '-classpath', ':'.join(classpath), | ||
| '-d', classes_dir] | ||
| '-d', classes_dir, | ||
| # TODO(camsim99): Make deprecation warnings fatal and remove limit |
Member
There was a problem hiding this comment.
This needs to be filed as as bug and the number cross-referenced here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compiler option to show the deprecation warnings when building the Android engine and a reminder to make these warnings fatal once the current ones are fixed.
As per this comment, I can confirm that this does not affect running
flutter run/flutter create.Pre-launch Checklist
///).