Add option to ignore newline style when comparing strings for equivalency #2565

vbreuss · 2024-01-16T07:01:26Z

Add the following option to the EquivalencyAssertionOptions<T> for strings

public EquivalencyAssertionOptions<T> IgnoringNewlineStyle()
{
    // This will replace "\r\n" with "\n" in actual and expected before comparison
    return this;
}

This fixes #2612 and fixes #2566

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

github-actions · 2024-01-16T07:05:28Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

coveralls · 2024-01-16T07:09:43Z

Pull Request Test Coverage Report for Build 8410472005

Details

26 of 26 (100.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 97.561%

Totals
Change from base Build 8409735285:	0.004%
Covered Lines:	12024
Relevant Lines:	12208

💛 - Coveralls

Src/FluentAssertions/Equivalency/SelfReferenceEquivalencyOptions.cs

Src/FluentAssertions/Primitives/StringAssertions.cs

github-actions · 2024-01-23T09:13:50Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

ivarne · 2024-02-03T20:34:25Z

Another option that would be cool here is to ignore newlines and indentation.

public EquivalencyAssertionOptions<T> IgnoreIndentation()
{
    // This will remove all whitespace after a newline in actual and expected before comparison
    return this;
}

dennisdoomen · 2024-03-21T06:38:05Z

@jnyrup will you be able to review this anything soon?

Src/FluentAssertions/Common/StringExtensions.cs

Src/FluentAssertions/Primitives/StringWildcardMatchingStrategy.cs

dennisdoomen · 2024-04-14T17:21:42Z

Nice!

Bumped FluentAssertions to 7.0.0-alpha.5 for fluentassertions/fluentassertions#2565

* CHG use keyed options to allow multiple definitions in one app * CHG make packet provider and related services keyed so they can be registered multiple times and injected by key * ADD Single executable to host both auth and game in one executable * feat(single): implement single exe * refactor(build): renamed Game + Auth to Game.Server + Auth.Server Executables are now just a tiny wrapper around the library to make QuantumCore.Single not depend on executables (causes many issues with build output) * feat(ci): single exe * feat(single): Add commandline parser to allow --version and --help * chore: Set author to MeikelLP to make auto generated copyright more useful * refactor(single): Moved Game.Server + Auth.Server to Libraries/ dir * fix: launchSettings.json * fix: project references * feat: Use IFileProvider Additionally removed the proto loaders and merged them with their respective manager * refactor(game): Use IFileProvider * refactor(game): Remove additional config files from data dir * fix: tests * refactor(game): Use IFileProvider * refactor(game): Use IFileProvider * refactor(game): Use ILoadable * fix(game): Duplicate service registration * fix: tests * fix: startup crash if no data/ dir existed * docs: renamed API to configuration * docs: Improve configuration docs * chore(docs): Add recommended truncate for blog posts * fix(tests) Bumped FluentAssertions to 7.0.0-alpha.5 for fluentassertions/fluentassertions#2565 * fix: InMemory cache wrong expiry * fix(game): service registration * fix: default IP is loopback * fix(auth): startup * fix(tests) * fix(game): remove unnecessary file IO * refactor: use constants for "auth" and "game" named options * chore: cleanup csproj * fix(single): bump GitVersion.MsBuild to latest to possibly fix CI issue * fix(ci): unshallow fetch * fix(ci): unshallow fetch * fix(single): app launch * fix(ci): self-contained publish for single * chore(ci): rename publish artifacts job * fix(game): ping handler casting wrongly * chore(docs): clarify the client directory * fix(ci): run single builds only on master/tag

Kryptos-FR · 2024-12-04T13:20:18Z

It seems like while it was included in the 7.0.0-alpha.4, it is not included in the 7.0 release. Why is that? I'm currently facing this exact issue.

jnyrup · 2024-12-04T14:16:56Z

It seems like while it was included in the 7.0.0-alpha.4, it is not included in the 7.0 release. Why is that? I'm currently facing this exact issue.

See #2864 (comment)

vbreuss marked this pull request as ready for review January 20, 2024 05:24

dennisdoomen approved these changes Jan 20, 2024

View reviewed changes

dennisdoomen requested a review from jnyrup January 20, 2024 07:04

ITaluone reviewed Jan 22, 2024

View reviewed changes

Src/FluentAssertions/Primitives/StringAssertions.cs Outdated Show resolved Hide resolved

dennisdoomen added the enhancement label Jan 26, 2024

vbreuss mentioned this pull request Mar 24, 2024

Add string-options for ignoring newline differences #2496

Closed

vbreuss changed the title ~~Add options to ignore all newlines and ignore newline style when comparing strings for equivalency~~ Add option to ignore newline style when comparing strings for equivalency Mar 24, 2024

vbreuss marked this pull request as draft March 24, 2024 15:50

vbreuss added 5 commits March 24, 2024 16:57

Add options to ignore all newlines and ignore newline style

899316a

Update documentation

b137e23

Implement review comments

4db3b82

Also use correct option in NotMatchEquivalentOf

bd86fa7

Remove IgnoringAllNewlines option

3e1489d

vbreuss marked this pull request as ready for review March 24, 2024 15:59

jnyrup reviewed Mar 29, 2024

View reviewed changes

Src/FluentAssertions/Common/StringExtensions.cs Show resolved Hide resolved

jnyrup reviewed Mar 29, 2024

View reviewed changes

Src/FluentAssertions/Primitives/StringWildcardMatchingStrategy.cs Show resolved Hide resolved

jnyrup approved these changes Apr 10, 2024

View reviewed changes

dennisdoomen merged commit 767ab78 into fluentassertions:develop Apr 14, 2024

vbreuss deleted the topic/add-option-to-ignore-newline-differences branch April 15, 2024 05:34

vbreuss mentioned this pull request Oct 26, 2024

Feature request: make a version from string BeEquivalentTo which ignores \n <> \r\n #1247

Open

MeikelLP added a commit to MeikelLP/quantum-core-x that referenced this pull request Nov 4, 2024

fix(tests)

a8966fb

Bumped FluentAssertions to 7.0.0-alpha.5 for fluentassertions/fluentassertions#2565

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add option to ignore newline style when comparing strings for equivalency #2565

Add option to ignore newline style when comparing strings for equivalency #2565

Uh oh!

vbreuss commented Jan 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

coveralls commented Jan 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2024 •

edited

Loading

Uh oh!

ivarne commented Feb 3, 2024 •

edited by jnyrup

Loading

Uh oh!

dennisdoomen commented Mar 21, 2024

Uh oh!

Uh oh!

Uh oh!

dennisdoomen commented Apr 14, 2024

Uh oh!

Kryptos-FR commented Dec 4, 2024

Uh oh!

jnyrup commented Dec 4, 2024

Uh oh!

Uh oh!

Add option to ignore newline style when comparing strings for equivalency #2565

Add option to ignore newline style when comparing strings for equivalency #2565

Uh oh!

Conversation

vbreuss commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT

Uh oh!

github-actions bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

coveralls commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 8410472005

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

ivarne commented Feb 3, 2024 • edited by jnyrup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dennisdoomen commented Mar 21, 2024

Uh oh!

Uh oh!

Uh oh!

dennisdoomen commented Apr 14, 2024

Uh oh!

Kryptos-FR commented Dec 4, 2024

Uh oh!

jnyrup commented Dec 4, 2024

Uh oh!

Uh oh!

vbreuss commented Jan 16, 2024 •

edited

Loading

github-actions bot commented Jan 16, 2024 •

edited

Loading

coveralls commented Jan 16, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

ivarne commented Feb 3, 2024 •

edited by jnyrup

Loading