opentelemetry: new abstraction to handle OTLP data #10549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsiper
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
…d up before releasing the underlying buffer Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
edsiper
force-pushed
the
opentelemetry-interface
branch
from
47cc35c to
b604fbe
Compare
|
CI issue with macos, all looks good. |
edsiper
added
opentelemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current codebase handles OTLP JSON, OTLP Protobuf, and Fluent Bit log chunk encoding directly within plugins like in_opentelemetry and out_opentelemetry, making the logic difficult to test and reuse in isolation.
This PR introduces the foundation for a new abstraction layer to centralize OTLP encoding and decoding tailored to Fluent Bit’s needs. As part of this change, in_opentelemetry now delegates OTLP Log JSON parsing to this new interface, and the legacy inline parsing logic has been deprecated.
In addition to improving testability and maintainability, the new interface introduces explicit encoding/decoding error types. These errors are now propagated to plugin consumers, enabling more informative and actionable error messages for end users when OTLP data fails to decode correctly.
as part of the changes, we added some minor fixes for protection in the pack and log_event_encoder_dynamic_field interfaces.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.