This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Refactor public API: put default peer API under Fluence facade #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alari
reviewed
Sep 10, 2021
| * @returns true if the object is FluencePeer false otherwise | ||
| */ | ||
| static isInstance(obj: FluencePeer): boolean { | ||
| if (obj && obj._isFluenceAwesome) { |
There was a problem hiding this comment.
(obj isInstanceOf FluencePeer) || (obj && obj._isFluenceAwesome)?
There was a problem hiding this comment.
(obj && obj._isFluenceAwesome) might return undefined. I wanted the return type to be strictly true\false
There was a problem hiding this comment.
Yeah, I'm about to check isInstanceOf on the first try.
There was a problem hiding this comment.
Ok, I'll add the check
There was a problem hiding this comment.
The compiler isn't happy:
property '_isFluenceAwesome' does not exist on type 'never'.ts(2339)
folex
reviewed
Sep 10, 2021
folex
approved these changes
Sep 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.