fix(tests): Repair integration tests [fixes DXJ-506] #364
Conversation
| @@ -22,6 +23,12 @@ const test = async () => { | |||
| await symlink(CDN_PUBLIC_PATH, join(publicPath, "source")); | |||
| } | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Can you please document what happens here and why?
Also, is it platform dependent in any way?
There was a problem hiding this comment.
I refactored it to self descriptive function.
Yes, it's platform independent
| try { | ||
| await access(join(publicPath, "deps")); | ||
| } catch { | ||
| await symlink(JS_CLIENT_DEPS_PATH, join(publicPath, "deps")); | ||
| } |
There was a problem hiding this comment.
let's move that to a separate function.
| @@ -42,7 +41,7 @@ export interface CallAquaFunctionArgs { | |||
| /** | |||
| * Peer to call the function on | |||
| */ | |||
| peer: IFluenceInternalApi; | |||
| peer: unknown; | |||
There was a problem hiding this comment.
This should be refactored and moved to JS-client. Previous type was essentially the same. I will add TODO to remember this.
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import type { Node } from "./commonTypes.js"; | |||
| import type { Node } from "@fluencelabs/interfaces"; | |||
There was a problem hiding this comment.
Does that refer to a published library, or to a local path?
If it refers to a published library, you might have bad time updating these types.
There was a problem hiding this comment.
Moved it to js-client side.
| export async function fetchResource( | ||
| pkg: string, | ||
| assetPath: string, | ||
| root: string, |
There was a problem hiding this comment.
what is root? need some doc
| export async function fetchResource( | ||
| pkg: string, | ||
| assetPath: string, | ||
| root: string, |
| assetPath: string, | ||
| root: string, | ||
| ) { | ||
| // `root` will be handled somehow in the future. For now, we use filesystem root where js-client is running; |
There was a problem hiding this comment.
| // `root` will be handled somehow in the future. For now, we use filesystem root where js-client is running; | |
| // TODO: `root` will be handled somehow in the future. For now, we use filesystem root where js-client is running; |
| @@ -85,7 +85,9 @@ const getRelayTime = () => { | |||
|
|
|||
| const main = async () => { | |||
| console.log("starting fluence..."); | |||
| fluence.defaultClient = await fluence.clientFactory(relay, {}); | |||
| fluence.defaultClient = await fluence.clientFactory(relay, { | |||
| CDNUrl: "http://localhost:3000", | |||
There was a problem hiding this comment.
Will URL be reported in an error, if it is not available?
There was a problem hiding this comment.
It will give you runtime error
There was a problem hiding this comment.
JS-client will throw when you try to run it
There was a problem hiding this comment.
will the error message include URL? I think it should
My vision on @fluencelabs/interface is that is should be private in our ecosystem. It should contain very generic types for reusing between avm , marine-js, marine-worker, aqua-to-js and other packages in our ecosystem. Thus I dont see a reason to keep js-client's config type in there |
| /** | ||
| * Node of the Fluence network specified as a pair of node's multiaddr and it's peer id | ||
| */ | ||
| export type Node = { |
There was a problem hiding this comment.
maybe rename since it's private now? like, Peer or something
No description provided.