feat(js-client)!: Adding strictes eslint and ts config to all packages [fixes DXJ-464]

.eslintrc.json

@@ -0,0 +1,162 @@
+{
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": 2022,
+        "project": [
+            "./tsconfig.eslint.json"
+        ],
+        "sourceType": "module"
+    },
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "plugin:import/recommended",
+        "plugin:import/typescript",
+        "prettier"
+    ],
+    "plugins": [
+        "@typescript-eslint",
+        "import",
+        "license-header",
+        "unused-imports"
+    ],
+    "ignorePatterns": [
+        "**/node_modules/**/*",
+        "**/dist/**/*"
+    ],
+    "rules": {
+        "eqeqeq": [
+            "error",
+            "always",
+            {
+                "null": "ignore"
+            }
+        ],
+        "no-console": [
+            "error"
+        ],
+        "arrow-body-style": [
+            "error",
+            "always"
+        ],
+        "no-empty": [
+            "error",
+            {
+                "allowEmptyCatch": true
+            }
+        ],
+        "curly": [
+            "error",
+            "all"
+        ],
+        "no-unused-expressions": [
+            "error"
+        ],
+        "dot-notation": [
+            "off"
+        ],
+        "object-curly-spacing": [
+            "error",
+            "always"
+        ],
+        "padding-line-between-statements": [
+            "error",
+            {
+                "blankLine": "always",
+                "prev": "multiline-expression",
+                "next": "*"
+            },
+            {
+                "blankLine": "always",
+                "prev": "*",
+                "next": "multiline-expression"
+            },
+            {
+                "blankLine": "always",
+                "prev": "multiline-block-like",
+                "next": "*"
+            },
+            {
+                "blankLine": "always",
+                "prev": "*",
+                "next": "multiline-block-like"
+            },
+            {
+                "blankLine": "always",
+                "prev": "multiline-const",
+                "next": "*"
+            },
+            {
+                "blankLine": "always",
+                "prev": "*",
+                "next": "multiline-const"
+            },
+            {
+                "blankLine": "always",
+                "prev": "multiline-let",
+                "next": "*"
+            },
+            {
+                "blankLine": "always",
+                "prev": "*",
+                "next": "multiline-let"
+            },
+            {
+                "blankLine": "any",
+                "prev": "case",
+                "next": "case"
+            }
+        ],
+        "import/extensions": [
+            "error",
+            "ignorePackages"
+        ],
+        "import/no-unresolved": "off",
+        "import/no-cycle": [
+            "error"
+        ],
+        "import/order": [
+            "error",
+            {
+                "newlines-between": "always",
+                "alphabetize": {
+                    "order": "asc",
+                    "caseInsensitive": true
+                }
+            }
+        ],
+        "node/no-unsupported-features/es-syntax": "off",
+        "node/no-unpublished-import": "off",
+        "node/no-missing-import": "off",
+        "@typescript-eslint/explicit-member-accessibility": [
+            "error",
+            {
+                "accessibility": "no-public"
+            }
+        ],
+        "@typescript-eslint/strict-boolean-expressions": [
+            "error",
+            {
+                "allowString": false,
+                "allowNumber": false,
+                "allowNullableObject": false,
+                "allowNullableBoolean": false,
+                "allowNullableString": false,
+                "allowNullableNumber": false,
+                "allowAny": false
+            }
+        ],
+        "@typescript-eslint/consistent-type-assertions": [
+            "error",
+            {
+                "assertionStyle": "never"
+            }
+        ],
+        "unused-imports/no-unused-imports": "error",
+        "license-header/header": [
+            "error",
+            "./resources/license-header.js"
+        ]
+    }
+}

.github/workflows/tests.yml

@@ -97,8 +97,9 @@ jobs:
               "@fluencelabs/marine-js": "${{ inputs.marine-js-version }}"
             }
 
-      - run: pnpm -r --no-frozen-lockfile i
+      - run: pnpm -r i
       - run: pnpm -r build
+      - run: pnpm lint-check
       - run: pnpm -r test
 
       - name: Dump rust-peer logs

.gitignore

@@ -1,5 +1,6 @@
 *.log
 .idea
+.eslintcache
 
 # Dependency directories
 node_modules/

package.json

@@ -8,15 +8,31 @@
     "node": ">=10",
     "pnpm": ">=3"
   },
+  "scripts": {
+      "lint-check": "pnpm run prettier --check && pnpm run eslint",
+      "lint-fix": "pnpm run prettier --write && pnpm run eslint --fix",
+      "prettier": "prettier \"**/src/**/*.{js,ts}\"",
+      "eslint": "eslint --cache \"**/src/**/*.{js,ts}\""
+  },
   "author": "Fluence Labs",
   "license": "Apache-2.0",
   "devDependencies": {
+    "@fluencelabs/aqua": "0.9.1-374",
+    "@fluencelabs/aqua-lib": "0.6.0",
+    "@total-typescript/ts-reset": "0.5.1",
+    "@tsconfig/strictest": "2.0.2",
+    "@types/node": "18.13.0",
+    "@typescript-eslint/eslint-plugin": "6.7.3",
+    "@typescript-eslint/parser": "6.7.3",
+    "eslint": "8.50.0",
+    "eslint-config-prettier": "9.0.0",
+    "eslint-plugin-import": "2.28.1",
+    "eslint-plugin-license-header": "0.6.0",
+    "eslint-plugin-unused-imports": "3.0.0",
     "http-server": "14.1.1",
+    "prettier": "3.0.3",
     "puppeteer": "19.7.2",
-    "@types/node": "18.13.0",
     "ts-node": "10.9.1",
-    "typescript": "4.7",
-    "@fluencelabs/aqua-lib": "0.6.0",
-    "@fluencelabs/aqua": "0.9.1-374"
+    "typescript": "5.1.6"
   }
 }

packages/@tests/.eslintrc.json

@@ -0,0 +1,8 @@
+{
+  "ignorePatterns": [
+    "**/*.css"
+  ],
+  "rules": {
+    "no-console": "off"
+  }
+}

packages/@tests/aqua/_aqua/smoke_test.aqua

@@ -53,3 +53,6 @@ func marineTest(wasm64: string) -> f64:
     <- res
 
 
+func callHappy(a: string, b: f64, c: f64, d: string -> f64) -> f64:
+    res <- d("abc")
+    <- res

packages/@tests/aqua/package.json

@@ -17,13 +17,13 @@
     "author": "Fluence Labs",
     "license": "Apache-2.0",
     "dependencies": {
-        "@fluencelabs/js-client": "workspace:^",
         "base64-js": "1.5.1"
     },
     "devDependencies": {
+        "@fluencelabs/aqua-lib": "0.6.0",
         "@fluencelabs/cli": "0.7.2",
+        "@fluencelabs/js-client": "workspace:^",
         "@fluencelabs/registry": "0.8.2",
-        "@fluencelabs/aqua-lib": "0.6.0",
         "@fluencelabs/trust-graph": "3.1.2"
     }
 }

packages/@tests/aqua/src/_aqua/finalize_particle.ts

@@ -8,13 +8,14 @@
  * Aqua version: 0.12.0
  *
  */
-import type { IFluenceClient as IFluenceClient$$, CallParams as CallParams$$ } from '@fluencelabs/js-client';
+import type {
+    IFluenceClient as IFluenceClient$$,
+    CallParams as CallParams$$,
+} from "@fluencelabs/js-client";
 import {
     v5_callFunction as callFunction$$,
     v5_registerService as registerService$$,
-} from '@fluencelabs/js-client';
-
-
+} from "@fluencelabs/js-client";
 
 // Services
 
@@ -30,49 +31,42 @@ export const test_script = `
                       (call %init_peer_id% ("errorHandlingSrv" "error") [%last_error% 0])
                      )
                     )
-    `
-
+    `;
 
-export function test(
-    config?: {ttl?: number}
-): Promise<void>;
+export function test(config?: { ttl?: number }): Promise<void>;
 
 export function test(
     peer: IFluenceClient$$,
-    config?: {ttl?: number}
+    config?: { ttl?: number },
 ): Promise<void>;
 
 export function test(...args: any) {
-
-
     return callFunction$$(
         args,
         {
-    "functionName" : "test",
-    "arrow" : {
-        "tag" : "arrow",
-        "domain" : {
-            "tag" : "labeledProduct",
-            "fields" : {
-
-            }
+            functionName: "test",
+            arrow: {
+                tag: "arrow",
+                domain: {
+                    tag: "labeledProduct",
+                    fields: {},
+                },
+                codomain: {
+                    tag: "nil",
+                },
+            },
+            names: {
+                relay: "-relay-",
+                getDataSrv: "getDataSrv",
+                callbackSrv: "callbackSrv",
+                responseSrv: "callbackSrv",
+                responseFnName: "response",
+                errorHandlingSrv: "errorHandlingSrv",
+                errorFnName: "error",
+            },
         },
-        "codomain" : {
-            "tag" : "nil"
-        }
-    },
-    "names" : {
-        "relay" : "-relay-",
-        "getDataSrv" : "getDataSrv",
-        "callbackSrv" : "callbackSrv",
-        "responseSrv" : "callbackSrv",
-        "responseFnName" : "response",
-        "errorHandlingSrv" : "errorHandlingSrv",
-        "errorFnName" : "error"
-    }
-},
-        test_script
-    )
+        test_script,
+    );
 }
 
-/* eslint-enable */
+/* eslint-enable */