feat: refactor configs [JS-831] #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MixailE
reviewed
Nov 6, 2024
| } else { | ||
| try { | ||
| // ensure env config also when provider.yaml exists | ||
| await access(getProviderConfigPath()); | ||
| setEnvConfig(await initNewEnvConfig()); | ||
| } catch { | ||
| const envConfig = await initEnvConfig(); |
There was a problem hiding this comment.
I added a global "cache" for all configs long ago (and for refactored configs I also added this "cache"), cause essentially when you init a config object you can reuse it for the duration of CLI running cause it is expected not to move anywhere, so there is no need anymore to store it globally separately, cause it's already stored globally anyway (there is a Map<configPath, config>).
MixailE
reviewed
Nov 6, 2024
MixailE
reviewed
Nov 6, 2024
… when using Promise.all that inits and manipulates the same config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.